No Code Attached Yet J4 Issue
avatar coolcat-creations
coolcat-creations
23 Nov 2017

image
Can the complete button be green and just one? It could redirect to the login page where there is a frontend link anyway?

Also it's not ready if i have still to complete something. So maybe "Almost ready" ?

avatar coolcat-creations coolcat-creations - open - 23 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 23 Nov 2017
avatar dgt41
dgt41 - comment - 23 Nov 2017

Also it's not ready if i have still to complete something. So maybe "Almost ready"

Depends on the outcome for sample data and extra languages, there is a debate to completely remove them from the installer

avatar mbabker
mbabker - comment - 23 Nov 2017

Also it's not ready if i have still to complete something. So maybe "Almost ready" ?

Technically it is ready. The site's usable, there are just some optional extras you can add with the languages and sample data. And unless we're going to add more conditional logic to detect when we actually enforce the "remove install directory" check, I don't think we need it to say "almost ready".

avatar coolcat-creations
coolcat-creations - comment - 23 Nov 2017

Then we don't need a complete because it's complete?

avatar brianteeman
brianteeman - comment - 23 Nov 2017

depends on if you think of it as an adjective or a verb? ;)

eg
To complete the site open the admin
The site is complete you can now open the admin

avatar brianteeman
brianteeman - comment - 23 Nov 2017

Personally as the title is already saying "your site is ready" then you only need "Open Site" and "Open Administrator"

Note it is Administrator not admin see style guide

avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Nov 2017
Category com_installer
avatar franz-wohlkoenig franz-wohlkoenig - change - 24 Nov 2017
Status New Discussion
avatar coolcat-creations
coolcat-creations - comment - 24 Nov 2017

So if the installation folder is still there it's definetly not complete for most of the users.
Is that option just on staging versions or always?

avatar mbabker
mbabker - comment - 24 Nov 2017

It's always there.

Removing it is not a requirement unless the version class is set to a stable release, which only happens when we are building the release packages. When running from the git repo, it's not enforced.

avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Aug 2018
Title
[4.0 Installer] Only one Complete Button and automatic redirect to the backend?
[4.0] [Installer] Only one Complete Button and automatic redirect to the backend?
avatar joomla-cms-bot joomla-cms-bot - edited - 21 Aug 2018
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 21 Aug 2018
avatar brianteeman brianteeman - change - 28 Aug 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 28 Aug 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Apr 2019
Title
[4.0] [Installer] Only one Complete Button and automatic redirect to the backend?
[4.0] Only one Complete Button and automatic redirect to the backend?
avatar franz-wohlkoenig franz-wohlkoenig - edited - 19 Apr 2019
avatar khu5h1
khu5h1 - comment - 3 Nov 2021

@brianteeman May we go with Open site and Open admin options instead of using Complete. I have understood it I may create a PR for this if it sounds good.

avatar richard67
richard67 - comment - 7 Nov 2021

@coolcat-creations Does PR #35988 solve it for you? Or should there be done more?

avatar richard67
richard67 - comment - 8 Nov 2021

As far as I can see the PR solves only a part of it, i.e. it still leaves 2 buttons.

avatar wilsonge wilsonge - change - 30 Jan 2022
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2022-01-30 21:31:26
Closed_By wilsonge
Labels Added: No Code Attached Yet
Removed: ?
avatar wilsonge wilsonge - close - 30 Jan 2022
avatar wilsonge
wilsonge - comment - 30 Jan 2022

I'm happy to take pull requests to improve the installer at any point. But going to close this for now as it's unlikely anything more is going to happen here given it's sat here for 3 years with no PRs and there's no clear proposals on how to improve the UX further.

Add a Comment

Login with GitHub to post a comment