[#18824] - [4.0] Move Users name above tabs on edit screen and remove 'Title' i.e username again.
- Closed
- 2 Apr 2018
- Medium
- Build: 4.0-dev
- Easy Test
- # 18824
- Diff
- tonypartridge:4.0-dev-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #18717 .
Summary of Changes
Removed old title text output
Added in new fieldset
Included name above the tabs
Follows Article Edit screen layout
Testing Instructions
Install, view / edit users.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
| Labels |
Added:
?
|
||
Thanks @franz-wohlkoenig
Please re-test.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18824.
@brianteeman could you test pretty please?
its for j4 - i am not testing anything ui related for j4 until we have the actual ui that is going to be used.
Yep, but it’s not really theming UI related more UX and this would pass trough on all theming.
On 24 Nov 2017, 21:28 +0000, Brian Teeman notifications@github.com, wrote:
its for j4 - i am not testing anything ui related for j4 until we have the actual ui that is going to be used.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
For edit.php, use this instead.
<?php echo JLayoutHelper::render('joomla.edit.title_alias', $this); ?>
@Quy Now updated @franz-wohlkoenig please re-test.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18824.
| Easy | No | ⇒ | Yes |
p.s. can we get re-tests.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18824.
This needs rebasing so that unit tests will run properly ?
@ggppdk now down, can you test and also @franz-wohlkoenig if you get a minute :-)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-02 19:17:57 |
| Closed_By | ⇒ | tonypartridge |
Will re do at some pointing, closing for now.
I have tested this item? unsuccessfully on e573908
Fieldset-Label:
Without PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18824.