? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
21 Nov 2017

Pull Request for Issue #18625

Summary of Changes

Fix the styling for the Save, Cancel and Versions buttons in the frontend editor.

avatar C-Lodder C-Lodder - open - 21 Nov 2017
avatar C-Lodder C-Lodder - change - 21 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2017
Category Front End com_content Layout Templates (site)
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Nov 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

I have tested this item ? unsuccessfully on b0d9c29

Works but Icon at "Versions" needs Space on the right Side:
bildschirmfoto 2017-11-21 um 15 05 46


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18775.
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

I have tested this item ? unsuccessfully on b0d9c29

Works but Icon at "Versions" needs Space on the right Side.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18775.
avatar C-Lodder
C-Lodder - comment - 21 Nov 2017

@franz-wohlkoenig - This PR should have deleted the following file for you:

templates/cassiopeia/html/layouts/joomla/form/field/contenthistory.php

If this file still exists for you, try manually deleting it.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

delete templates/cassiopeia/html/layouts/joomla/form/field/contenthistory.php manually, Result is wrong Icon:

bildschirmfoto 2017-11-21 um 15 13 24

avatar C-Lodder
C-Lodder - comment - 21 Nov 2017

Not the wrong icon, I purposely replaced the folder icon with the code-fork icon as it's a better visual indicator.

Same change applied to the toolbar in the backend template too ;)

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

I have tested this item successfully on b0d9c29


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18775.

avatar C-Lodder C-Lodder - change - 21 Nov 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 22 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-22 13:14:31
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Nov 2017
avatar wilsonge wilsonge - merge - 22 Nov 2017

Add a Comment

Login with GitHub to post a comment