[#18768] - Edit article - add a tag by pressing enter or regular comma
- Fixed in Code Base
- 24 Nov 2017
- Medium
- Build: staging
- # 18768
- Diff
- csthomas:separate_tags_by_comma
User tests: Successful: Unsuccessful:
Pull Request for Issue #10761
- Related and inspired by #12366
- Do not add comma (
,) to tags
Summary of Changes
- Wrap code in function to use for a new event.
- Check for comma in
keypressevent - Check for enter in
keyupevent - Do not add a comma to tag
- Use check
event.charCode == 44for comma which should fix the issue.
Testing Instructions
See #10761
Expected result
Fix mentioned issue and comma is not added at the end of tag when you are pressing comma.
Actual result
Comma is added at the end of tag.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I hope it become a part of Joomla in the next release, which helps a lot of users
@A-Kasaaian if you test we have one of two needed Test so Release Lead can decide if merge or not.
FWIW we’re working in a new tags custom element for j4 which also supports this behavior and also drag and drop for rearranging the order of the tags. The wip code is here: https://codepen.io/dgt41/pen/KvbbdE
@franz-wohlkoenig As I have provided the solution about one year ago and reviewed it about 2 month ago. I've tested it multiple times. I'm sure it works fine with all languages. Here is the solution I wrote and csthomas created this pull request based on that. csthomas has mentioned all needed links in the first comment.
thank you @csthomas for helping and correcting changes.
@dgt41 Can we mark comments from @A-Kasaaian and @Quy as success tests?
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-24 18:06:41 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I don't know jQuery, however, I tested it successfully, Can it still be counted toward a success test?