Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18756] - Add forum ID to language string

? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Nov 2017

Crowdin doesn't allow to translate empty strings.

Summary of Changes

This PR adds the default forum ID to the language string.
There is no change in functionality as there is currently a fallback to the same value.

joomla-cms/administrator/components/com_admin/views/help/tmpl/langforum.php

Lines 14 to 19 in 5e8ea37

$forumId = (int) JText::_('MOD_MENU_HELP_SUPPORT_OFFICIAL_LANGUAGE_FORUM_VALUE');
if (empty($forumId))
{
$forumId = 511;
}

Testing Instructions

Test that the link to the language forum works

Expected result

Works

Actual result

Works but can't be translated using Corwdin.

Documentation Changes Required

Maybe translation doc.

avatar Bakual Bakual - open - 20 Nov 2017
avatar Bakual Bakual - change - 20 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2017
Category ⇒ Administration Language & Strings
avatar infograf768
infograf768 - comment - 20 Nov 2017

511 is fine
https://forum.joomla.org/viewforum.php?f=511

avatar Quy Quy - test_item - 20 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 20 Nov 2017

I have tested this item ✅ successfully on 56d9772

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18756.

avatar infograf768 infograf768 - test_item - 21 Nov 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 21 Nov 2017

I have tested this item ✅ successfully on 56d9772

grrr... crowdin :)

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18756.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Nov 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 24 Nov 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-11-24 18:07:08
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 24 Nov 2017
avatar mbabker mbabker - merge - 24 Nov 2017

Add a Comment

Login with GitHub to post a comment