User tests: Successful: Unsuccessful:
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
?
|
@hans2103 Do you thing that PR will be useful? Can you test it?
This PR does not use MobileDetect.net but it should be easy to use workaround:
JFactory::getConfig()->set('cache_platformprefix', 0);
and manually set the cache option platformKey
based on MobileDetect.net.@ptest8794 @ggppdk
You may be interested in adding a comment or testing this PR.
Hi
i've tested the changes on my test site.
with these mods the layout on tablet and mobile is loaded correctly.
But this changes not cover all tablets platforms (for example windows tablets)
If is it possible integrare mobile detect library in joomla core should be the better solution
I would like to add Mobile_Detect too but I do not know if we can do that in J3.x.
This PR is not perfect but is closer to our goal and after 2 tests has a chance to go with 3.8.x.
By using Mobile_Detect you will have to wait at least to J3.9 or J4.0.
If we're going to add Mobile_Detect we need a good plan for how to phase out the two other browser detection classes we have in the API and not just lump in a third.
I see that this PR did not satisfy anyone.
Without 2 successful test it won't be merged to joomla.
In the case of Mobile-Detect, this is a more complex issue, which was mentioned by @mbabker.
I'm not interested to extend this PR at now.
If there won't more comments/tests I will close this PR.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-31 19:09:44 |
Closed_By | ⇒ | csthomas |
I have fixed the code style, please take a look again.
Can someone restart the drone?