[#18724] - [4.0] Offsets separated by white space(s) are deprecated, use a comma (,) instead.
- Closed
- 25 Mar 2018
- Medium
- Build: staging
- # 18724
Steps to reproduce the issue
Joomla 4 Alpha 2
Mouseover a popover e.g:
Expected result
No console messages
Actual result
repeatedly
System information (as much as possible)
| Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Status | New | ⇒ | Confirmed |
the error is generated because of the following line of code in bootstrap.bundle.js
console.warn("Offsets separated by white space(s) are deprecated, use a comma (,) instead.")
I don't really find any use of this line of code or any important error that this code might signify.
And removing it does solve the issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18724.
deleting an error message is not a fix for removing the error - ever
Alright. A small change in bootstrap.php at line 259 solved it.
earlier:
$opt['offset'] = isset($params['offset']) ? $params['offset'] : '0 0';
now:
$opt['offset'] = isset($params['offset']) ? $params['offset'] : '0,0';
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18724.
Are you going to submit a pull request or do you expect someone else to do it (because thats not how it works)
I was waiting for a confirmation. Anyway, I've made a PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18724.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-03-25 05:44:17 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2018-03-25 05:44:17 | ⇒ | 2018-03-25 05:44:18 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18724
Issue confirmed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18724.