?
avatar PhilETaylor
PhilETaylor
19 Nov 2017

Steps to reproduce the issue

Not so much a bug, more aesthetic..
Edit a user in Joomla 4 admin (or Joomla 3)

Expected result

Something sensible.

Actual result

There is an output of the users name (not username) above the Account details tab that is not needed. It makes no sense to have this here, as well as an editable textbox, especially as if you edit the textbox which contains this value, then the one above the tabs is not updated until the page is saved. In Joomla 4 template (currently) looks worse than in Joomla 3

screen shot 2017-11-19 at 17 58 53

screen shot 2017-11-19 at 17 56 07

avatar PhilETaylor PhilETaylor - open - 19 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 19 Nov 2017
avatar PhilETaylor PhilETaylor - change - 19 Nov 2017
The description was changed
avatar PhilETaylor PhilETaylor - edited - 19 Nov 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Nov 2017
Category com_users UI/UX
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Nov 2017
Status New Discussion
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Nov 2017

+1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18717.

avatar tonypartridge
tonypartridge - comment - 21 Nov 2017

+1

avatar brianteeman
brianteeman - comment - 22 Nov 2017

This was added by @infograf768 https://developer.joomla.org/joomlacode-archive/issue-31060.html

The logic behind it was that if you are on a tab then there is no indicator which user you are editing

(not saying if i agree or disagree I am just reporting the history)

It is a 2 second fix if required

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Nov 2017

thanks for Info @brianteeman and: true, so close my "+1".

avatar tonypartridge
tonypartridge - comment - 22 Nov 2017

It’s still duplicating work, why not add username: to the top on each additional fieldset which is non editable?

On 22 Nov 2017, 18:04 +0000, Franz Wohlkönig notifications@github.com, wrote:

thanks for Info @brianteeman and: true, so close my "+1".

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar brianteeman
brianteeman - comment - 22 Nov 2017

i dont see what the "duplicated work" is or how your proposal is any better than the current onw

avatar tonypartridge
tonypartridge - comment - 22 Nov 2017

I mean duplicate data on the first screen.

Because you are adding it into a container rather than outside and it’s only shown once, you wouldn’t show it on the first tab since it’s a text edit field there.

On 22 Nov 2017, 18:13 +0000, Brian Teeman notifications@github.com, wrote:

i dont see what the "duplicated work" is or how your proposal is any better than the current onw

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar brianteeman
brianteeman - comment - 22 Nov 2017

Think about the a11y of it. The page should know the username from a title tag not a field

avatar PhilETaylor
PhilETaylor - comment - 22 Nov 2017

A (very very very badly mocked up) image of what I think @tonypartridge is proposing, and what is a very easy solution:

32993643-ef482b48-cd52-11e7-970d-74a90579cdd7

and
32993669-53b28c68-cd53-11e7-94bb-b3c6bd3478bd

avatar tonypartridge
tonypartridge - comment - 22 Nov 2017

Exactly!

Or if we must have a duplicate username let’s chuck it up the top next to Edit Profile (Super User)

On 22 Nov 2017, 18:25 +0000, Phil Taylor notifications@github.com, wrote:

A (very very very badly mocked up) image of what I think @tonypartridge is proposing, and what is a very easy solution:

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar PhilETaylor
PhilETaylor - comment - 22 Nov 2017

This mockup is exactly what we do for Articles, where the title is above a tab, as a form field, and not as a "title" above the tabs, with the form field buried in a tab. E.g.

screen shot 2017-11-22 at 18 29 25

avatar brianteeman
brianteeman - comment - 22 Nov 2017

that seems logical - sorry if i didnt understand you tony

its an easy change

avatar tonypartridge
tonypartridge - comment - 23 Nov 2017

@PhilETaylor are you going to do a pull? Or should I?

avatar PhilETaylor
PhilETaylor - comment - 23 Nov 2017

You can, Im neck deep in rewriting myJoomla.com for a Christmas release.

avatar tonypartridge
tonypartridge - comment - 23 Nov 2017

Great, PR sent.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Nov 2017
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2017-11-23 13:03:22
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 23 Nov 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Nov 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Nov 2017

closed as having Pull Request #18824

avatar tonypartridge
tonypartridge - comment - 10 Feb 2018

@lodder see:
#18824

On 10 Feb 2018, 11:49 +0000, Lodder notifications@github.com, wrote:

Please reopen

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar C-Lodder
C-Lodder - comment - 10 Feb 2018

yeah sorry, wrong issue

Add a Comment

Login with GitHub to post a comment