? ? Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
19 Nov 2017

Pull Request for Issue # .

Summary of Changes

This PR fixes Operand should contain 1 column(s) when saving user profile. See #18698 to issue description and how to re-procedure it

I also made some small improvements to the code like re-use $query object + calls $query->values directly in the loop.

Testing Instructions

  1. See #18698 and confirm the issue
  2. Apply patch, confirm that the error is gone
avatar joomdonation joomdonation - open - 19 Nov 2017
avatar joomdonation joomdonation - change - 19 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2017
Category Front End Plugins
avatar joomdonation joomdonation - change - 19 Nov 2017
Labels Added: ?
avatar infograf768 infograf768 - test_item - 21 Nov 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 21 Nov 2017

I have tested this item successfully on c4a185c

Works fine here.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18705.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

@Reijo83 can you please test?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

@Reijo83 thanks for test, please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar Reijo83 Reijo83 - test_item - 21 Nov 2017 - Tested successfully
avatar Reijo83
Reijo83 - comment - 21 Nov 2017

I have tested this item successfully on c4a185c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18705.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Nov 2017

Ready to Commit after two successful tests.

avatar joomdonation
joomdonation - comment - 2 Dec 2017

@wilsonge Shouldn't this PR get merged?

avatar wilsonge wilsonge - change - 2 Dec 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-12-02 13:52:36
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Dec 2017
avatar wilsonge wilsonge - merge - 2 Dec 2017
avatar wilsonge
wilsonge - comment - 2 Dec 2017

Yes it should :)

avatar joomdonation
joomdonation - comment - 2 Dec 2017

Thanks !

Add a Comment

Login with GitHub to post a comment