User tests: Successful: Unsuccessful:
Pull Request for Issue #18626 .
Attempts to fix versioning in the frontend. I'm very unsure about the quality of this fix. But it does work
Checking versioning in the frontend editing view works
It works
Fatal Error
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_content com_contenthistory |
Labels |
Added:
?
|
Title |
|
This might work for history but it isn't portable. The way getController is called by default it makes all of the existing config override logic just not work and I don't think we need to be overloading getController to repeat logic we're already running elsewhere (or move that logic into extended methods).
It depends what we want to do with the Application object. It's not exactly the most sustainable thing to create an admin app instance i guess. There are various ways to make this more pretty from a method overriding perspective
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-19 11:24:28 |
Closed_By | ⇒ | wilsonge |
Status | Closed | ⇒ | New |
Closed_Date | 2017-11-19 11:24:28 | ⇒ | |
Closed_By | wilsonge | ⇒ |
Status | New | ⇒ | Pending |
AFAIK you don't need to have an admin app instance to make it work right (we aren't doing that now in the proxies). The issue we have is getController is called without passing a client argument by default so it's resolving to the active app to generate namespaces, and in these proxy cases we need to explicitly state admin client to get the namespaces right.
It's not just getController
- it's also in the MVC factories
Same root issue. Without explicit client it resolves to active app. Honestly it's a higher level problem than this because there's so much dependent on active app and we shouldn't have to inject another one to make things work.
Which is why i said earlier
It depends what we want to do with the Application object
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-07-21 17:16:30 |
Closed_By | ⇒ | brianteeman |
I have tested this item? unsuccessfully on 4cd835a
Firefox: Modal Window open and closed.
Chrome: cmd+Click on "Versions" open Modal which stay open but Buttons (Rstore … Delete) don't work after Click on them.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18679.