? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Nov 2017

Pull Request for Issue #18626 .

Summary of Changes

Attempts to fix versioning in the frontend. I'm very unsure about the quality of this fix. But it does work

Testing Instructions

Checking versioning in the frontend editing view works

Expected result

It works

Actual result

Fatal Error

avatar wilsonge wilsonge - open - 18 Nov 2017
avatar wilsonge wilsonge - change - 18 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2017
Category Front End com_content com_contenthistory
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Nov 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Nov 2017

I have tested this item ? unsuccessfully on 4cd835a

Firefox: Modal Window open and closed.
Chrome: cmd+Click on "Versions" open Modal which stay open but Buttons (Rstore … Delete) don't work after Click on them.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18679.

avatar wilsonge wilsonge - change - 18 Nov 2017
Labels Added: ?
avatar wilsonge wilsonge - change - 19 Nov 2017
Title
Fix dispatcher to use the backend
[4.0] Fix dispatcher to use the backend
avatar wilsonge wilsonge - edited - 19 Nov 2017
avatar mbabker
mbabker - comment - 19 Nov 2017

This might work for history but it isn't portable. The way getController is called by default it makes all of the existing config override logic just not work and I don't think we need to be overloading getController to repeat logic we're already running elsewhere (or move that logic into extended methods).

avatar wilsonge
wilsonge - comment - 19 Nov 2017

It depends what we want to do with the Application object. It's not exactly the most sustainable thing to create an admin app instance i guess. There are various ways to make this more pretty from a method overriding perspective

avatar wilsonge wilsonge - change - 19 Nov 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-11-19 11:24:28
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Nov 2017
avatar wilsonge wilsonge - change - 19 Nov 2017
Status Closed New
Closed_Date 2017-11-19 11:24:28
Closed_By wilsonge
avatar wilsonge wilsonge - change - 19 Nov 2017
Status New Pending
avatar wilsonge wilsonge - reopen - 19 Nov 2017
avatar mbabker
mbabker - comment - 19 Nov 2017

AFAIK you don't need to have an admin app instance to make it work right (we aren't doing that now in the proxies). The issue we have is getController is called without passing a client argument by default so it's resolving to the active app to generate namespaces, and in these proxy cases we need to explicitly state admin client to get the namespaces right.

avatar wilsonge
wilsonge - comment - 19 Nov 2017

It's not just getController - it's also in the MVC factories

avatar mbabker
mbabker - comment - 19 Nov 2017

Same root issue. Without explicit client it resolves to active app. Honestly it's a higher level problem than this because there's so much dependent on active app and we shouldn't have to inject another one to make things work.

avatar wilsonge
wilsonge - comment - 19 Nov 2017

Which is why i said earlier

It depends what we want to do with the Application object

avatar brianteeman
brianteeman - comment - 21 Jul 2018

closed see #21208

avatar brianteeman brianteeman - change - 21 Jul 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-07-21 17:16:30
Closed_By brianteeman
avatar brianteeman brianteeman - close - 21 Jul 2018

Add a Comment

Login with GitHub to post a comment