? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
18 Nov 2017

Pull Request for Issue #18609.

Summary of Changes

The params column is not used in field groups, this pr removes them.

Ping @Bakual, can you please confirm that it is ok to remove the column?

Testing Instructions

Create a field group.

Expected result

Works.

Actual result

Error is shown.

avatar laoneo laoneo - open - 18 Nov 2017
avatar laoneo laoneo - change - 18 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Nov 2017
Category SQL Administration com_admin Postgresql
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 18 Nov 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Nov 2017

I have tested this item ? unsuccessfully on 5b24d9a

Using PR Issue is still the same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18676.

avatar laoneo
laoneo - comment - 18 Nov 2017

Did you delete the columns in the DB table?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 18 Nov 2017

No, i applied the PR and test.

avatar Bakual
Bakual - comment - 18 Nov 2017

Removing the column is fine. We're not using it, at least not currently ?

avatar wilsonge
wilsonge - comment - 19 Nov 2017

Can we remove it from the installation sql files too please :) otherwise it's still going to be created

avatar laoneo laoneo - change - 19 Nov 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2017
Category SQL Administration com_admin Postgresql SQL Administration com_admin Postgresql Installation
avatar laoneo
laoneo - comment - 19 Nov 2017

Done.

avatar wilsonge wilsonge - change - 19 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-19 13:25:35
Closed_By wilsonge
avatar wilsonge wilsonge - close - 19 Nov 2017
avatar wilsonge wilsonge - merge - 19 Nov 2017
avatar wilsonge
wilsonge - comment - 19 Nov 2017

Thanks!

avatar wilsonge
wilsonge - comment - 19 Nov 2017

OK We got this one wrong. #17317 was why this got put in

avatar wilsonge
wilsonge - comment - 19 Nov 2017

@laoneo Can you please submit a PR which reverts this one and just stores and empty json string in the db like we originally discussed before we decided to remove this

avatar Bakual
Bakual - comment - 20 Nov 2017

I wasn't even aware of that PR ?

avatar laoneo
laoneo - comment - 20 Nov 2017

Pr has landed, #18753.

Add a Comment

Login with GitHub to post a comment