Feeling Lucky
?
[#18648] - [4.0] Drone CS failures
- Closed
- 24 Nov 2017
- Medium
- Build: staging
- # 18648
FILE: ...ithub.com/joomla/joomla-cms/libraries/src/Console/CleanCacheCommand.php
22s
46
--------------------------------------------------------------------------------
22s
47
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
22s
48
--------------------------------------------------------------------------------
22s
49
55 | ERROR | Opening parenthesis of a multi-line function call must be the
22s
50
| | last content on the line
22s
51
--------------------------------------------------------------------------------
22s
52
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
22s
53
--------------------------------------------------------------------------------
22s
54
22s
55
22s
56
FILE: ...hub.com/joomla/joomla-cms/libraries/src/Console/CheckUpdatesCommand.php
22s
57
--------------------------------------------------------------------------------
22s
58
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
22s
59
--------------------------------------------------------------------------------
22s
60
62 | ERROR | Opening parenthesis of a multi-line function call must be the
22s
61
| | last content on the line
22s
62
--------------------------------------------------------------------------------
22s
63
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
22s
64
--------------------------------------------------------------------------------
22s
65
22s
66
22s
67
FILE: ...b.com/joomla/joomla-cms/libraries/src/Console/RemoveOldFilesCommand.php
22s
68
--------------------------------------------------------------------------------
22s
69
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
22s
70
--------------------------------------------------------------------------------
22s
71
61 | ERROR | Opening parenthesis of a multi-line function call must be the
22s
72
| | last content on the line
22s
73
--------------------------------------------------------------------------------
22s
74
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
22s
75
----
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
brianteeman
- comment
- 18 Nov 2017
Ah - that explains why I couldnt submit a fix ;)
franz-wohlkoenig
- | Category | ⇒ | Code style |
| Status | New | ⇒ | Discussion |
mbabker
- comment
- 18 Nov 2017
Well, the ugly fix is to assign the nowdoc contents to a variable so those lines become $this->setHelp($help); but that just ignores the sniffer bug.
brianteeman
- comment
- 18 Nov 2017
over my head
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-24 19:52:09 |
| Closed_By | ⇒ | brianteeman |
It's an issue with the code sniffer, it's not accepting nowdoc syntax as valid. https://github.com/joomla-framework/console doesn't have PHPCS issues and uses the same syntax in the repo but uses our PHPCS 2 ruleset so the issue is either a bug in PHPCS 1.x or one of the CMS repo's custom rules having some bad logic.