Feeling Lucky
[#1863] - #31892 remove unnecessary code
- Closed
- 30 Aug 2013
- Medium
- Build: master
- # 1863
- Diff
- nueckman:tablenested
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Removing unnecessary code: We move a node, so the title and alias aren't changed.
sybrek
- comment
- 30 Aug 2013
Thanks Elin. Haven't tought about that. Pull Request closed.
Actually you may well have to update them if there is a duplicate alias. You don't know whether that means it will fail or it will generate an alias and title with a 2 until you see how the table is handling duplicates. The alias is also used for rebuilding the path. I'll do a closer review but I think there are good reasons for insuring that the only two required fields are set.