?
avatar davidhavard
davidhavard
10 Apr 2012

Hi

In libraries/joomla/updater/adaptors/extension.php on line 46 & 47 you will find the following two lines:

$this->current_update->folder = "";
$this->current_update->client_id = 1;

These bascially hardcode the updater to look for extensions that have a client_id of 1 and no folder. The problem here is that it effectively blocks updates for any extension that uses a client_id of 0 (site templates, libraries, plugins and modules) and any that use folders (plugins).

I am not familiar enough with this area of the Joomla code but a have had a look around it seems the best solution would be too include these in the update manifest using and tags. If they are not specified it can set these defaults to ensure backwards compatibility while allowing those who need it to get these updates working.

This code appears to have come out of this discussion: https://groups.google.com/forum/#!msg/joomla-dev-general/R4g0-Q2pWXk/SmLaJEsTUK0J where the suggested clumsy alternative seems the better option?

I am happy to make these changes and provide a patch unless someone has a better suggestion?

Thanks
Dave

avatar davidhavard davidhavard - open - 10 Apr 2012
avatar davidhavard
davidhavard - comment - 10 Apr 2012

Ignore - found how to override this now.

avatar zero-24 zero-24 - close - 10 Apr 2012
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?
Build staging

Add a Comment

Login with GitHub to post a comment