? Error

User tests: Successful: Unsuccessful:

avatar pdxfixit
pdxfixit
29 Aug 2013

Recently, YouTube changed the embed URLs provided, so that they are protocol agnostic;

<iframe width="560" height="315" src="//www.youtube.com/embed/bRdOBbluWgc" frameborder="0" allowfullscreen></iframe>

While <iframes> are, indeed, disallowed in most cases, the concept of a protocol-agnostic URL is not new, and continues to rise in prominence.

This fix should prevent URLs like the one shown above, from having JURI::base() concatenated to the beginning.

avatar pdxfixit pdxfixit - open - 29 Aug 2013
avatar brianteeman
brianteeman - comment - 2 Sep 2013

Thanks for the contribution - Can you please also do the following

1) Open an item on the Joomlacode tracker in the appropriate area.

CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103

CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549

2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item and the GitHub issue or pull request.

avatar vdespa
vdespa - comment - 14 Sep 2014

There has been no real progress on this issue, so I am closing it for the moment. The PR needs to be redone agains the staging branch and some testing instructions are needed.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar jissues-bot jissues-bot - close - 14 Sep 2014
avatar jissues-bot
jissues-bot - comment - 14 Sep 2014

Set to "closed" on behalf of @vdespa by The JTracker Application at issues.joomla.org

avatar jissues-bot jissues-bot - close - 14 Sep 2014
avatar vdespa vdespa - change - 14 Sep 2014
Status New Closed
Build master
avatar jissues-bot jissues-bot - change - 14 Sep 2014
Closed_Date 0000-00-00 00:00:00 2014-09-14 07:12:18
avatar pdxfixit
pdxfixit - comment - 14 Sep 2014

For the record; I'm not interested in double-entry systems. (hence the lack of Joomlacode tracker item)
My hope had been, that this Pull Request would be enough to add this minor fix.

All the best.

avatar vdespa
vdespa - comment - 15 Sep 2014

At this point there is no need for a Joomlacode item, as the new tracker (issues.joomla.org) is integrated with github. To get this merged / fixed, a couple of things need to be done. Just sending a PR (as you can see), does not instantly fix things.

  • You need to resubmit your change against the staging branch.
  • Testing instructions are needed
  • Any b/c issues need to be discussed / tested.
  • At least to testers need to confirm the issue and that the fix works as expected.

Thanks for your contribution.

Add a Comment

Login with GitHub to post a comment