Joomla! Issue Tracker | Joomla! CMS #18581 - Fix popover hidden behind modal header

? ?

Fixed in Code Base
18 Nov 2017
Medium
Build: staging
# 18581
Diff
Quy:patch-12

Pending

User tests: Successful: Unsuccessful:

Quy
16 Nov 2017

Pull Request for Issue #15028.

Summary of Changes

Change placement of popover from top to bottom.

Testing Instructions

Edit article.
Under Publishing tab, click blue button to Select User.
Hover mouser over a column header.

Expected result

Popover to be visible.

Actual result

Popover partially hidden under modal header.

Documentation Changes Required

None

6c0578c 16 Nov 2017

Fix popover hidden behind modal header

Quy - open - 16 Nov 2017

Quy - change - 16 Nov 2017

Status

New

⇒

Pending

joomla-cms-bot - change - 16 Nov 2017

Category

⇒

Administration com_users

infograf768 - comment - 16 Nov 2017

@Quy
We do have the same issue for all modals.
Can you enlarge your PR to include these?

diff --git a/administrator/components/com_categories/views/categories/tmpl/modal.php b/administrator/components/com_categories/views/categories/tmpl/modal.php
index 5c6dc12..027db8f 100644
--- a/administrator/components/com_categories/views/categories/tmpl/modal.php
+++ b/administrator/components/com_categories/views/categories/tmpl/modal.php
@@ -24,4 +24,5 @@
 JHtml::_('behavior.core');
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 
diff --git a/administrator/components/com_contact/views/contacts/tmpl/modal.php b/administrator/components/com_contact/views/contacts/tmpl/modal.php
index 0553535..52f5162 100644
--- a/administrator/components/com_contact/views/contacts/tmpl/modal.php
+++ b/administrator/components/com_contact/views/contacts/tmpl/modal.php
@@ -23,4 +23,6 @@
 JHtml::_('behavior.core');
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
+
 JHtml::_('formbehavior.chosen', 'select');
 JHtml::_('behavior.polyfill', array('event'), 'lt IE 9');
diff --git a/administrator/components/com_content/views/articles/tmpl/modal.php b/administrator/components/com_content/views/articles/tmpl/modal.php
index 87d90d7..c148e7f 100644
--- a/administrator/components/com_content/views/articles/tmpl/modal.php
+++ b/administrator/components/com_content/views/articles/tmpl/modal.php
@@ -26,4 +26,5 @@
 JHtml::_('script', 'com_content/admin-articles-modal.min.js', array('version' => 'auto', 'relative' => true));
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('behavior.multiselect');
 JHtml::_('formbehavior.chosen', '.multipleTags', null, array('placeholder_text_multiple' => JText::_('JOPTION_SELECT_TAG')));
diff --git a/administrator/components/com_fields/views/fields/tmpl/modal.php b/administrator/components/com_fields/views/fields/tmpl/modal.php
index 49d63ab..d2e551c 100644
--- a/administrator/components/com_fields/views/fields/tmpl/modal.php
+++ b/administrator/components/com_fields/views/fields/tmpl/modal.php
@@ -17,4 +17,5 @@
 JHtml::_('behavior.core');
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 JHtml::_('script', 'com_fields/admin-fields-modal.js', array('version' => 'auto', 'relative' => true));
diff --git a/administrator/components/com_menus/views/items/tmpl/modal.php b/administrator/components/com_menus/views/items/tmpl/modal.php
index 3d4a9ef..a7b12e9 100644
--- a/administrator/components/com_menus/views/items/tmpl/modal.php
+++ b/administrator/components/com_menus/views/items/tmpl/modal.php
@@ -23,4 +23,5 @@
 JHtml::_('script', 'com_menus/admin-items-modal.min.js', array('version' => 'auto', 'relative' => true));
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 
@@ -119,5 +120,5 @@
 							<?php else : ?>
 								<?php echo $this->escape($item->title); ?>
-							<?php endif; ?>	
+							<?php endif; ?>
 							<span class="small">
 								<?php if (empty($item->note)) : ?>
diff --git a/administrator/components/com_modules/views/modules/tmpl/modal.php b/administrator/components/com_modules/views/modules/tmpl/modal.php
index 8178467..dd60240 100644
--- a/administrator/components/com_modules/views/modules/tmpl/modal.php
+++ b/administrator/components/com_modules/views/modules/tmpl/modal.php
@@ -18,4 +18,5 @@
 JHtml::_('behavior.core');
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 
diff --git a/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php b/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php
index 10ab99a..7a695bf 100644
--- a/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php
+++ b/administrator/components/com_newsfeeds/views/newsfeeds/tmpl/modal.php
@@ -16,4 +16,5 @@
 JHtml::_('behavior.core');
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 
diff --git a/administrator/components/com_users/views/users/tmpl/modal.php b/administrator/components/com_users/views/users/tmpl/modal.php
index 93ffdd2..e75112f 100644
--- a/administrator/components/com_users/views/users/tmpl/modal.php
+++ b/administrator/components/com_users/views/users/tmpl/modal.php
@@ -13,4 +13,5 @@
 
 JHtml::_('bootstrap.tooltip', '.hasTooltip', array('placement' => 'bottom'));
+JHtml::_('bootstrap.popover', '.hasPopover', array('placement' => 'bottom'));
 JHtml::_('formbehavior.chosen', 'select');
 JHtml::_('behavior.multiselect');

ciar4n - comment - 16 Nov 2017

Presuming this PR moves the popover under rather that over, does that not mean the popover partially covers the table column it is explaining. The PR is still an improvement.. just not sure if it is ideal.

infograf768 - comment - 16 Nov 2017

Not under vs over but down vs up (up being the default).
Indeed it partially covers the column, but only when hovering the column title, which is OK imho as it is not partially hidden now.

a5d3c4a 16 Nov 2017

Fix popover hidden behind modal header

Quy - change - 16 Nov 2017

Labels

Added: ?

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users

⇒

Administration com_categories com_users

e292e58 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories

⇒

Administration com_categories com_contact com_users

1a837de 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories com_contact

⇒

Administration com_categories com_contact com_content com_users

d92f548 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories com_contact com_content

⇒

Administration com_categories com_contact com_content com_fields com_users

a71772c 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories com_contact com_content com_fields

⇒

Administration com_categories com_contact com_content com_fields com_menus com_users

f0d68be 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories com_contact com_content com_fields com_menus

⇒

Administration com_categories com_contact com_content com_fields com_menus com_modules com_users

afcea4d 16 Nov 2017

Fix popover hidden behind modal header

joomla-cms-bot - change - 16 Nov 2017

Category

Administration com_users com_categories com_contact com_content com_fields com_menus com_modules

⇒

Administration com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_users

Quy - comment - 16 Nov 2017

@infograf768 Done. Thank you!

infograf768 - test_item - 17 Nov 2017 - Tested successfully

infograf768 - comment - 17 Nov 2017

I have tested this item ✅ successfully on afcea4d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18581.}

franz-wohlkoenig - test_item - 17 Nov 2017 - Tested successfully

franz-wohlkoenig - comment - 17 Nov 2017

I have tested this item ✅ successfully on afcea4d

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18581.}

franz-wohlkoenig - change - 17 Nov 2017

Status

Pending

⇒

Ready to Commit

franz-wohlkoenig - comment - 17 Nov 2017

RTC after two successful tests.

ladyjer - test_item - 18 Nov 2017 - Tested successfully

ladyjer - comment - 18 Nov 2017

I have tested this item ✅ successfully on afcea4d

Successfully tested in 3.8.3-dev

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18581.}

mbabker - change - 18 Nov 2017

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2017-11-18 15:10:40
Closed_By		⇒	mbabker
Labels	Added: ?

mbabker - close - 18 Nov 2017

mbabker - merge - 18 Nov 2017

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#18581] - Fix popover hidden behind modal header

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Add a Comment