Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18573] - Fix Undefined index: JHtmlBootstrap::startAccordion / JHtmlBootstrap::startTabSet

? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
14 Nov 2017

Pull Request for Issue #17853.

Summary of Changes

Contact links section does not have the accordion/tab initialization code so when it is the first section to display, the slide/tab cannot be added to.

Testing Instructions

Install Test English Sample Data demo.
Enable Maximum for Error Reporting.
Under Configuration > Contacts > Contact, set Contact Information to hide.
On front end, click Featured Contacts.
Click Shop Address contact.

Expected result

No notice warnings.

Actual result

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 693

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 694

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 695

or

Notice: Undefined index: JHtmlBootstrap::startTabSet in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 788

Documentation Changes Required

None

avatar Quy Quy - open - 14 Nov 2017
avatar Quy Quy - change - 14 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Nov 2017
Category ⇒ Front End com_contact
avatar C-Lodder
C-Lodder - comment - 28 Nov 2017

If the following doesn't cause any errors, it should be used instead:

<?php if ($presentation_style === 'sliders') : ?>
	<?php if (!$accordionStarted) : ?>
		<?php echo JHtml::_('bootstrap.startAccordion', 'slide-contact', array('active' => 'display-links')); ?>
		<?php $accordionStarted = true; ?>
	<?php endif; ?>
<?php elseif ($presentation_style === 'tabs') : ?>
	<?php if (!$tabSetStarted) : ?>
		<?php echo JHtml::_('bootstrap.startTabSet', 'myTab', array('active' => 'display-links')); ?>
		<?php $tabSetStarted = true;  ?>
	<?php endif; ?>
<?php endif; ?>
avatar Quy Quy - change - 30 Nov 2017
Labels Added: ?
avatar ladyjer ladyjer - test_item - 5 Dec 2017 - Tested successfully
avatar ladyjer
ladyjer - comment - 5 Dec 2017

I have tested this item ✅ successfully on 5a06904

@C-Lodder version works too. CS with ':' should be preferred, but CS with '{' is used everywhere in default.php for second level if statements.
I don't know which one is then best.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.
avatar ladyjer
ladyjer - comment - 5 Dec 2017

@C-Lodder version works too. CS with ':' should be preferred, but CS with '{' is used in this default.php for every second level if.
I don't know which one of the two is the best.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.

avatar Quy
Quy - comment - 5 Dec 2017

Per Joomla's Coding Standards, read Mixed language usage (e.g. at the layout files). Be sure to scroll up a little bit.

avatar Quy Quy - change - 23 Dec 2017
The description was changed
avatar Quy Quy - edited - 23 Dec 2017
avatar Quy
Quy - comment - 23 Dec 2017

@franz-wohlkoenig can you test please?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 23 Dec 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Dec 2017

I have tested this item ✅ successfully on 5a06904

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Dec 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Dec 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 3 Jan 2018
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-01-03 00:15:16
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Jan 2018
avatar mbabker mbabker - merge - 3 Jan 2018

Add a Comment

Login with GitHub to post a comment