? Pending

User tests: Successful: Unsuccessful:

avatar Erftralle
Erftralle
11 Nov 2017

Summary of Changes

Adds the neccesarry Javascript for the strength meter in the password form field layout.

Testing Instructions / Steps to reproduce the issue

Joomla! does not use any password form field with activated strength meter, so to reproduce the issue you have to edit administrator/components/com_admin/models/forms/profile.xml and add the attribute strengthmeter="true" to the field named password2.
Log in to the backend and navigate to 'My Profile'.
Type in some chars into the 'Password' field.

Expected result

The strength meter should be displayed when typing in some chars into the password input field.

Actual result

No strength meter appears, the Javascript error 'ReferenceError: Form is not defined' occurs.

After applying the patch the password strenght meter should be displayed again.

avatar Erftralle Erftralle - open - 11 Nov 2017
avatar Erftralle Erftralle - change - 11 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2017
Category Layout
avatar Quy Quy - test_item - 11 Nov 2017 - Tested successfully
avatar Quy
Quy - comment - 11 Nov 2017

I have tested this item successfully on eddc73c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18556.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Nov 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

I have tested this item ? unsuccessfully on eddc73c

Test on Super User but didn't get a strength meter.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18556.

avatar Quy
Quy - comment - 12 Nov 2017

Be sure to follow the testing instructions to add the attribute in the designated file.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

I have tested this item successfully on eddc73c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18556.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 12 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-12 23:32:27
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 12 Nov 2017
avatar wilsonge wilsonge - merge - 12 Nov 2017
avatar wilsonge
wilsonge - comment - 12 Nov 2017

Thanks!

avatar infograf768
infograf768 - comment - 13 Nov 2017

Any reason why the modification to profile.xml is not included in the patch?

avatar wilsonge
wilsonge - comment - 13 Nov 2017

Is there a reason to use the strengthmeter in core?

avatar infograf768
infograf768 - comment - 13 Nov 2017

??

avatar wilsonge
wilsonge - comment - 13 Nov 2017

You asked why the modification to profile.xml wasn't in the patch?

avatar infograf768
infograf768 - comment - 13 Nov 2017

And then, I wonder why we have the possibility of a strenghtmeter if we do not use it in core. I am confused.

avatar infograf768
infograf768 - comment - 13 Nov 2017

It is very easy to implement wherever the field is present
registration
screen shot 2017-11-13 at 10 49 36

My Profile

screen shot 2017-11-13 at 10 46 32

Installation

screen shot 2017-11-13 at 10 53 34

Would be nice imho

avatar brianteeman
brianteeman - comment - 13 Nov 2017

Except that as shown in the screenshots it is meaningless.

avatar infograf768
infograf768 - comment - 13 Nov 2017

it means something to me as the meter grows in size and changes color from red to dense green.

avatar brianteeman
brianteeman - comment - 13 Nov 2017

I can not see the difference between red and green

avatar dgt41
dgt41 - comment - 13 Nov 2017

You realise that the script is Mootools dependant, right?

avatar brianteeman
brianteeman - comment - 13 Nov 2017

Can we please stop adding things that completely fail accessibility to Joomla. In this example if you want to do it then you can create a layout override for it on your site.

Add a Comment

Login with GitHub to post a comment