It would be nice if this was accessible there are lots of accessible progress bar examples online

@brianteeman Add accessible.

@Fedik Use Joomla.renderMessages()

I have tested this item ✅ successfully on b82544e

@asika32764 how to get "fatal error without standard JSON format or HTTP error status" to test PR?

Actually I don't know. Maybe return a XML output. This case should never happened.

In this PR, all response with HTTP 200 will go to done() method, but the PHP post_max_size error is unable to catch and returned with JSON and HTTP 200 status:

If jQuery try to parse JSON but fail, it will go to error() method. And if response is HTTP 4xx-5xx status will go error() too. I handled the error.responseText for any PHP fatal error and error.responseJSON for standard JSON output, so it should has no other cases we will get.

@franz-wohlkoenig Sorry, I misunderstand what you asked. The "fatal error without standard JSON format or HTTP error status" is the post_max_size issue.

Set php.ini post_max_size to a small value and upload a big file, you will get error message. Before this PR, the uploader will return no message.

If you upload an extension with fatal error in it's install script, this PR will also show the error message. Before this PR it will lose respond and running forever.

This works with drag and drop, but not with Or browse for file. Is this intentional?

Yes, Or browse for file use file input and post form to upload package. While the drag and drop use ajax (because JS cannot insert value to file input).

On a local install, the progress bar moves to 100% very quickly, and then takes about 10 seconds to complete. So this is an upload indicator only and not an installing indicator too?

Yes, it is only uploading indicator. Joomla didn't implement the installing indicator interface now.

In Microsoft Edge 41.16299.15.0 on Windows 10, you don't see the progress bar until the very end. Also, should the % be next to the number without the space?

good spot. yes it would read better without the space between the number and the &

• Removed space
• Added installing progress after uploaded. See:

@Quy About the Edge issue, it is a known bug that MS haven't fixed it. See:

• https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/12224510/
• https://stackoverflow.com/questions/43942396/ajax-file-upload-progress-upload-event-does-not-fire-in-edge-browser

I have tested this item ✅ successfully on a00243c

ok

I have tested this item ? unsuccessfully on 7b6ed58

I do not have an alert popup when the package size exceeds the upload_max_filesize value.
Nothing happening, I have only this message : "No Install Type Found".
This problem is recurring on my host where the upload_max_filesize is set to 2Mo.
Great PR, but it does not work as expected.

@twister65

The test case with error message is post_max_size.

PHP won't catch upload_max_size error, it will still run process without any uploaded file, so Joomla cannot find extension package file and return a No Install Type Found message.

See #18554 (comment)

At here we use message instead of alert popup.
#18554 (comment)

@asika32764 , if I set post_max_size to 2 MB, and I upload a file larger than 2 MB. Then the message is "No Install Type Found" and there is no alert popup. This message is not relevant.

Then the message is "No Install Type Found" and there is no alert popup.

This is expected behavior,the default error message should show as Joomla message, not popup.

This PR try to catch some PHP error which Joomla cannot catch and notify user, without this PR, the uploader will only infinite loop without any response.

The popup screenshot you see in first post is no longer used, we use message box now. See #18554 (comment)

This message is not relevant.

This message is default Joomla install error message, not belongs to this PR.

I have tested this item ✅ successfully on 7b6ed58

RTC

I have tested this item ✅ successfully on 5a68c03

As the last change is just cosmetic, let's keep this as RTC.