? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
10 Nov 2017

Pull Request for Issue #18542.

Summary of Changes

check only if not core.admin

Testing Instructions

see #18542

avatar alikon alikon - open - 10 Nov 2017
avatar alikon alikon - change - 10 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2017
Category Administration com_modules
avatar alikon alikon - change - 10 Nov 2017
Labels Added: ?
299036a 11 Nov 2017 avatar alikon cs
avatar infograf768
infograf768 - comment - 11 Nov 2017

Still missing deleting the tabs line 323 ;)

418e91e 11 Nov 2017 avatar alikon tab
avatar infograf768 infograf768 - test_item - 11 Nov 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 11 Nov 2017

I have tested this item successfully on 418e91e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18548.

avatar csthomas
csthomas - comment - 11 Nov 2017

Please make dron happy:

FILE: ...omla/joomla-cms/administrator/components/com_modules/models/modules.php
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 317 | ERROR | Please consider a blank line preceding your comment
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
avatar infograf768
infograf768 - comment - 11 Nov 2017

Drone is too polite to be human... ?

avatar alikon
alikon - comment - 11 Nov 2017

drone still unhappy but now not my fault ?

avatar rdeutz
rdeutz - comment - 11 Nov 2017

I restarted the job so drone is now happy too :-)

avatar infograf768 infograf768 - alter_testresult - 12 Nov 2017 - infograf768: Tested successfully
avatar infograf768
infograf768 - comment - 12 Nov 2017

As the corrected drone misbehavior has no impact on tests, we just need another tester to get this RTC

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

As i can't find Test Instructions on #18542 can @infograf768 you please give them?

avatar alikon
alikon - comment - 12 Nov 2017

Steps to reproduce the issue:

1. Go into the backend of Joomla as super user and add a new module.
2. Change module access to Guest Access.
3. check that that module is not visbile in com_modules items list

Expected result

Module should be visible in module list even if module access is set to Guset

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 12 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

I have tested this item successfully on 1ad1308

Thanks for Test Instructions @alikon


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18548.

avatar franz-wohlkoenig franz-wohlkoenig - change - 12 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 18 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-18 15:12:25
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 18 Nov 2017
avatar mbabker mbabker - merge - 18 Nov 2017
avatar ladyjer ladyjer - test_item - 18 Nov 2017 - Tested successfully
avatar ladyjer
ladyjer - comment - 18 Nov 2017

I have tested this item successfully on 1ad1308


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18548.

Add a Comment

Login with GitHub to post a comment