J3 Issue ?
avatar joris85
joris85
9 Nov 2017

Steps to reproduce the issue

Enable the button - menu
Edit an article
Select some text you want to link to a menu item
Click on the button Menu that is appeard after enabling plugin.
Choose a menu item and click on it.
instead of making my selected text linked it replaced my selected text for menu item name.

Expected result

If i have selected any text it should make that text linked instead of replacing.

Actual result

My text is deleted and my menu item name is linkable placed instead of it.

System information (as much as possible)

Joomla 3.8
PHP 7
Chrome on mac

Additional comments

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar joris85 joris85 - open - 9 Nov 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Nov 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Nov 2017
Category com_plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Nov 2017

@infograf768 guess its expected Behaviour #11721?

avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Nov 2017
Status New Information Required
avatar brianteeman
brianteeman - comment - 9 Nov 2017

Agree with @joris85 this is not expected

avatar joris85
joris85 - comment - 9 Nov 2017

Thanks Brian :-)
Is there someone who can fix this issue?

avatar infograf768
infograf768 - comment - 9 Nov 2017

It was conceived this way. It is expected.
It works the same for the Articles button.

avatar brianteeman
brianteeman - comment - 9 Nov 2017

Doesn't mean it's the correct expected behaviour

avatar infograf768
infograf768 - comment - 9 Nov 2017

What I mean is that if that effect is desired, then it has to be modified also for other buttons: articles, menu, contact.

avatar joris85
joris85 - comment - 9 Nov 2017

Well who desired that?
The user experience is that your text disappears.
So if you ask me desired or not it is not user friendly and not working as a normal customer could expect.
I think this feature is awesome but will not show this my customer before it is working like you expect. Even for me it is not working good.

I select a text, choose a menu to link to, it is replacing that text so i need to edit the link. Halfway you need to place your cursor to stay it a link and after you typed you need to delete the stuff in front and back of the created link.
If that is desired than i desire other user experience i think :-D

I wish you all a great day!

avatar infograf768
infograf768 - comment - 10 Nov 2017

@joris85
This is the way it has been working for these xtd from the first one (article) created a long time ago.
I am absolutely not opposing this improvement which has to be done via JS.
I personally would not know how to make such a patch.

@dgt41
Can you devise a solution? I guess it is in the modal js

avatar dgt41
dgt41 - comment - 10 Nov 2017

Select some text you want to link to a menu item

To be able to make that text link we need to move all the xtd buttons to native tinymce plugins. This is a limitation on the current architecture but we started already creating native plugins for j4 (check the image button)

avatar infograf768
infograf768 - comment - 10 Nov 2017

@dgt41
I guess the OP idea is that it would work whatever the editor chosen.

avatar dgt41
dgt41 - comment - 10 Nov 2017

@infograf768 there is a way, I guess I need to try it: the xtd plugins always replace the selected text, so if the code is aware that there is some text selected (eg sent an event with the selected text, or empty if nothing is selected) then with a simple if statement we can recompile the desired output. There are couple of gotchas with this approach:

  • j3 still supports ie8, meaning we need to use jquery
  • j4 will come with an event bus so the events need to be future proof

Let me play around with this idea the next days and I will come up with my findings

avatar infograf768
infograf768 - comment - 10 Nov 2017

@dgt41
Thanks for looking.

avatar joris85
joris85 - comment - 10 Nov 2017

@dgt41
That sounds awesome! i hope you will have good findings :-)

@infograf768
The fact that it is working from the beginning of time with the article is probobly the reason why i always disable all the buttons :-D

My end users have no experience with website's so Wordpress it sometimes a better solution for them. But for me Joomla is a better solution haha
I think that if the focus of joomla would be frontend super easy and backend flexible, joomla would be more powerfull and easy than Wordpress.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Dec 2017

@dgt41 any Progress on this Issue?

avatar joris85
joris85 - comment - 26 Dec 2017

Yeah i would like to know to (:
Is this maybe fixed in 3.8.4?

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Jan 2018
Status Information Required Discussion
avatar brianteeman brianteeman - change - 25 Mar 2018
Labels Added: J3 Issue
avatar brianteeman brianteeman - labeled - 25 Mar 2018
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2018
Status Duplicate Report Closed
Closed_By Quy joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 25 May 2018
avatar Quy Quy - change - 25 May 2018
Status Discussion Duplicate Report
Closed_Date 0000-00-00 00:00:00 2018-05-25 02:32:13
Closed_By Quy
avatar joomla-cms-bot
joomla-cms-bot - comment - 25 May 2018

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/18538

avatar Quy
Quy - comment - 25 May 2018

Duplicate of #17665


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18538.

Add a Comment

Login with GitHub to post a comment