[#18536] - [com_fields] Multilanguage: fixing display of fields when the item concerned is set to ALL
- Fixed in Code Base
- 24 Nov 2017
- Medium
- Build: staging
- # 18536
- Diff
- infograf768:multilang_fields
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18396 , replaces #18474
Issue: An item (article in that case) tagged to ALL languages is displaying all fields tagged to specific languages.
Summary of Changes
When an item is tagged to ALL languages, only display custom fields tagged to ALL languages as well as custom fields tagged to the Active language.
Testing Instructions
Create a multilingual site. 2 Content languages are enough. Here for en-GB and fr-FR
Structure:
===>Categories
===>Articles set as Featured
===> Home menu as Featured Articles menu item for each language.
===> Create some articles custom fields and assign languages, including ALL
Expected result
Example for articles for a multingual site with 2 Content Languages:
For an article tagged to ALL, only custom fields tagged to ALL as well as custom fields tagged to the Active language should display.
This to follow the current behavior of any item on a multilang site: items set to ALL display whatever the language, items set to a specific language only display when the language is the active one.
Actual result
Custom fields tagged to ALL as well as custom fields tagged to any Content Language are displayed
Before patch
French
English
After Patch
French
English
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
Patch ok for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18536.
@ajejebrazorf01 can you please test?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18536.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@laoneo
Shall I now create a PR for the profile issue with the code I proposed here?
#18474 (comment)
Free to all to propose a better solution, if it exists.
I can have a look on JWC.
Can you make a pr with the proper testing instructions, I can't reproduce it. Probably I do something wrong.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-24 18:11:03 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
This PR does not solve yet the filtering of User custom fields (profile) as discussed in #18474 (comment)