[#18522] - Fix Joomla! search highlighting when including chars like ) (. Create…
- Fixed in Code Base
- 3 Jan 2018
- Medium
- Build: staging
- # 18522
- Diff
- tonypartridge:staging-search-title-fix
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18478 .
Allows () and all other characters to be used in titles and searched with highlighting.
Summary of Changes
Moved original code into a function for each calling to highlight and avoid duplicating code.
Testing Instructions
Create a search menu item
Create an article with ) in the title or ( and all other characters you can think of.
Search this in the frontend.
Expected result
the searched text to be highlighted in the results
Actual result
partial highlighting of the text and title isn't. Plus error:
Warning: preg_replace(): Compilation failed: missing ) at offset 10 in [WEBDIR]/components/com_search/views/search/view.html.php on line 270
Is output.
NOTE: just done on my laptop, may need to fix drone etc as haven't setup codesniffer properly yet.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_search |
| Labels |
Added:
?
|
||
Tried from "[Art" to "[Articl" Letter by Letter, but Article isn't found.
Article is found if search for "[Article".
So to confirm the article isn't found at all or the searched word isn't highlighted?
Article using Title "This is (Test) [Article]" is found and searched Word is highlighted if search for "[Article".
Article isn't found if search for "[Art", "[Arti", "[Artic", "[Articl".
That is expected behaviour @franz-wohlkoenig
This pull only addresses keyword highlighting.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18522.
I have tested this item
Tested
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18522.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
@franz-wohlkoenig Please remove RTC as there are questions/changes to be done.
| Status | Ready to Commit | ⇒ | Pending |
Drone won't start
But @dtdpro and @franz-wohlkoenig please can I get a retest :-)
not just you - drone is bjorked
Hehe it is Christmas! :p someone Clearly did not pray to the IT Gods, I blame @wilsonge.
On 22 Dec 2017, 23:16 +0000, Brian Teeman notifications@github.com, wrote:
not just you - drone is bjorked
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18522.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18522.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-03 00:16:42 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on 8287ad7
Article using Title "This is (Test) [Article]" is by Searching full Title.
Searching for "[art" Article isn't found.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18522.