Feeling Lucky
?
[#18520] - Remove alt text for language flag images also if not dropdown list
- Closed
- 7 Nov 2017
- Medium
- Build: staging
- # 18520
- Diff
- richard67:patch-2
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for no Issue.
Summary of Changes
If an image is only used for decorative purposes then the alt tag should be blank so that screen readers will not announce it.
See PR #18475
Testing Instructions
Test that without this PR, the flag images have alt texts and with this PR they don't, when using flags displayed as icons (i.e. not drowdown list) in the language switcher module.
Expected result
No alt tag.
Actual result
Alt tag.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
richard67
- comment
- 7 Nov 2017
@brianteeman I just notice that in this case, the images are for navigation and not only for decorative purposes, so this PR here is wrong. I close it now. Sorry for disturbing.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-07 19:19:34 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
|
||
@brianteeman Please check and if possible review or test.
Btw. drone failed but for reasons not related to this PR.