? ? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
6 Nov 2017

Pull Request for Issue #18503

Summary of Changes

  • Removes support for ReCaptcha v1
  • Removes the (customized) recaptchalib.php file and migrates to Google's PHP ReCaptcha library
  • Adds a bridge class implementing their RequestMethod interface to use our HTTP adapter
  • Makes all library classes available in global libraries (bridge class and the Google library), should make it less required for extension devs to ship these resources if they choose not to use the core captcha implementation

Testing Instructions

  • ReCaptcha just works

Documentation Changes Required

  • Note removed v1 support
  • Note new library support
avatar mbabker mbabker - open - 6 Nov 2017
avatar mbabker mbabker - change - 6 Nov 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2017
Category Repository External Library Composer Change Libraries Front End Plugins
avatar brianteeman
brianteeman - comment - 6 Nov 2017

The language file needs updating as well to remove the 1.0 strings

avatar mbabker mbabker - change - 6 Nov 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 6 Nov 2017
Category Repository External Library Composer Change Libraries Front End Plugins Repository Administration Language & Strings External Library Composer Change Libraries Front End Plugins
avatar mbabker
mbabker - comment - 6 Nov 2017

The language file needs updating as well to remove the 1.0 strings

Done

avatar wilsonge
wilsonge - comment - 8 Nov 2017

Looks good. Can you fix conflict please and we'll get this merged in :)

avatar mbabker mbabker - change - 8 Nov 2017
Labels Added: ?
avatar mbabker
mbabker - comment - 8 Nov 2017

Done.

avatar wilsonge wilsonge - change - 8 Nov 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-08 01:08:34
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Nov 2017
avatar wilsonge wilsonge - merge - 8 Nov 2017
avatar zero-24
zero-24 - comment - 8 Nov 2017

I have just added the Documentation required label so at some time we remember to document the changes made here.

Add a Comment

Login with GitHub to post a comment