[#18485] - Fix undefined $langCode
- Fixed in Code Base
- 4 Nov 2017
- Medium
- Build: staging
- # 18485
- Diff
- tonypartridge:patch-4
User tests: Successful: Unsuccessful:
Pull Request for Issue #18484 .
When calling JHelperContent::getCurrentLanguage() within an extension where multilang fails we check agains $langCode but it hasn't been set, so set it before we do anything.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
How to test this Pull Request?
@obuisard can you test please?
@franz-wohlkoenig it's an awkward one to test!
Tested successfully with one of my extensions. Thank you!
Note that I have also updated my code to prevent calls to getCurrentLanguage in a non-multi-lingual site :-)
@obuisard can you please mark as successful here:
https://issues.joomla.org/tracker/joomla-cms/18485
you will need to login first with your github account :)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18485.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-04 14:36:13 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 74d4ab2
Makes sense.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18485.