Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18483] - [postgresql] - schema change rework

? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
2 Nov 2017

Pull Request for Issue #14331 and porting of #17351.

Summary of Changes

support these schema changes:

  • ALTER TABLE "#__table" ALTER COLUMN "field" SET NOT NULL;
  • ALTER TABLE "#__table" ALTER COLUMN "field" SET DEFAULT value;
  • ALTER TABLE "#__table" ALTER COLUMN "field" DROP DEFAULT;
  • ALTER TABLE "#__table" ALTER COLUMN "field" DROP NOT NULL;

Testing Instructions

With latest staging on postgresql go to Manage > Database.

Expected result

no notice

Actual result

Notice: Undefined offset:....

@waader , @csthomas please re-test, review

avatar alikon alikon - open - 2 Nov 2017
avatar alikon alikon - change - 2 Nov 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2017
Category ⇒ Libraries
avatar csthomas
csthomas - comment - 5 Nov 2017
  1. I have not spent enough time on it but when I changed database table by:
ALTER TABLE "#__extensions" ALTER COLUMN "custom_data" DROP NOT NULL;
ALTER TABLE "#__extensions" ALTER COLUMN "custom_data" SET DEFAULT '';

then joomla does not see any problems, but should show that DEFAULT values was removed in

joomla-cms/administrator/components/com_admin/sql/updates/postgresql/3.7.0-2017-03-03.sql

Line 1 in 0ac5c79

ALTER TABLE "#__extensions" ALTER COLUMN "custom_data" DROP DEFAULT;

  1. There is a white space on line 117.
avatar alikon alikon - change - 30 Dec 2017
Labels Added: ?
avatar alikon
alikon - comment - 30 Dec 2017

1 and 2 fixed

avatar alikon alikon - change - 2 Jan 2018
The description was changed
avatar alikon alikon - edited - 2 Jan 2018
avatar alikon alikon - change - 2 Jan 2018
The description was changed
avatar alikon alikon - edited - 2 Jan 2018
avatar alikon alikon - change - 2 Jan 2018
Title
…
[postgresql] - remove notice from manage database
[postgresql] - schema change rework
avatar alikon alikon - edited - 2 Jan 2018
avatar alikon
alikon - comment - 2 Jan 2018

reworked a little bit for use information_schema.columns

42ba37a 3 Jan 2018 avatar alikon cs
avatar alikon
alikon - comment - 3 Jan 2018

@Quy hope cs better now

avatar alikon
alikon - comment - 3 Jan 2018

sorry & thanks @Quy for your extra-work still fighting with the local setup of phpcs ?

avatar alikon
alikon - comment - 21 Feb 2018

please test #19707

avatar alikon alikon - change - 21 Feb 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-02-21 19:28:18
Closed_By ⇒ alikon
avatar alikon alikon - close - 21 Feb 2018

Add a Comment

Login with GitHub to post a comment