Feeling Lucky
[#1848] - Start PHPCS for the framework DI
- Closed
- 28 Aug 2013
- Medium
- Build: master
- # 1848
- Diff
- wilsonge:phpcs
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Fix some of the PHPCS issues in framework DI package
I'm probably going to just exempt the
libraries/frameworkfolder from our PHPCS checks. The Framework repo is using the proper coding standards definition whereas the CMS doesn't have the full ruleset implemented and also has some tweaks for reasons I don't remember anymore (this was all set up a year ago).With that said, you should send up these fixes over to the Framework repo. I'm willing to bet if you examine the Travis output from the last build, these same issues are highlighted.