[#18476] - PHP Warning: Parameter 1 to PlgSystemLogout::handleError() expected to be a reference, value given in /libraries/legacy/error/error.php on line 780
- Closed
- 30 Dec 2017
- Medium
- Build: staging
- # 18476
Steps to reproduce the issue
Log in frontend ( I did as superadmin).
Login form module is set to display on all pages.
Edit an article.
Logout through the module
You get that Warning. Logout is done OK
Note: test done on a clean staging multilingual site
| Labels |
Added:
?
|
||
You get that, but the Warning shows in the PHP error logs, not on the page.
Had looked before Comment in php_error.log, didn't get it there too.
| Category | ⇒ | Authentication Front End |
| Status | New | ⇒ | Discussion |
weird
@infograf768 I can reproduce the warning in the error log.
@Quy @franz-wohlkoenig
I see that Franz did his test while using a test sample data while I just had used the default multilang setting when installing J.
Quy, what your were your settings?
Installed Test English (GB) Sample Data demo.
Edit an article in the front end.
Click the Log out button.
View error log.
Thanks for info.
Test again on clean Install: No Warning in php_error.log.
System information
3.8.4-dev
Multilanguage Site (4 Lang.) & Test English (GB) Sample Data
macOS Sierra, 10.12.6
Firefox 57 (64-bit)
MAMP 4.2
- PHP 7.0.22
- MySQLi 5.6.35
@franz-wohlkoenig
Have you tested when the article is in the edit state, i.e. not saved yet?
2 Versions:
- Open Article, change something, click on Log-out-Button of Module (there comes PopUp "Do you really wanna leave Page")
- Open Article and click on Log-out-Button of Module
In both Cases no Warning.
I think I found why we have that.
the method is
public static function handleError(&$error) in /plugins/system/logout/logout.php
If I change to public static function handleError($error)
No more Warning
It may be related to the PHP version as using the reference is there for compatibility with php 5.3
What is weird is that @franz-wohlkoenig does not get the issue although he uses a 7.x php version.
Maybe it is related to his 7.0.22 bersion?
My version of PHP is 7.1.8
I confirm: using php 7.0.22 does NOT throw the warning
@infograf768 confirm: got Error after changing PHP-Version to 7.1.8 in Mamp.
PHP 7.1.11 & PHP 7.2.0
Maybe this will give some insights: https://forum.joomla.org/viewtopic.php?t=930067
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-12-30 16:18:22 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18476
Can't confirm. Logout by Module (display on all Pages) give:
