User tests: Successful: Unsuccessful:
Continuing the work to ensure that all uses of font icons are accessible and following the advice of Font Awesome (http://fontawesome.io/accessibility/) this PR ensures that the interactive icons used in category views in the front end to expand or collapse the display of subcategories have both an aria-label on the link and aria-hidden on the icon.
Note the code is different to other related PR as the icon is changed with JS
The easiest way to test is with the tesing sample data installed and then the "contact categories" and the "article categories" menu items - see video
Status | New | ⇒ | Pending |
Category | ⇒ | Front End com_contact com_content com_newsfeeds Language & Strings |
Labels |
Added:
?
?
|
I have tested this item
@brianteeman - I was thinking more along the lines of, if we want to use it for 3rd party extensions or the collapse custom element in J4
@C-Lodder for accessibility the text should be meaningful so it needs the "category" part so you know what you are showing more of. I think what is confusing right now is the key that I have used for the PR as it is very generic and not specific to categories. As I stated in the original post I am seeking guidance from @infograf768 for the correct key to use and these keys are just for testing purposes. For your use case in J4 we can have different strings possibly with a sprintf
@brianteeman I think @C-Lodder is right, correcting thins per view is gonna be a lot of repeated code instead of using a global collapse custom element specific to joomla's needs. That said this PR is against staging, so no CE thus it's ok the way you're doing it, but for J4 we need to use Custom Element for such behaviours
Do what you want for J4 - this is for J3. I have given up looking at j4 as all development has pretty much stopped while waiting for ux and a11y team
as all development has pretty much stopped while waiting for ux and a11y team
Sadly that's true
I these new strings are strictly related to categories, I suggest to change the constants to
JGLOBAL_EXPAND_CATEGORIES
and JGLOBAL_COLLAPSE_CATEGORIES
Thanks @infograf768 i will update the pr with those keys
Thanks @brianteeman
I have tested this item
Based on code review
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:13:47 |
Closed_By | ⇒ | mbabker |
Thanks
JGLOBAL_COLLAPSE="Show less categories"
are you should you want to go with that? What if it's not a category? Perhaps just?