? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Oct 2017

Continuing the work to ensure that all uses of font icons are accessible and following the advice of Font Awesome (http://fontawesome.io/accessibility/) this PR ensures that the interactive icons used in category views in the front end to expand or collapse the display of subcategories have both an aria-label on the link and aria-hidden on the icon.

Note the code is different to other related PR as the icon is changed with JS

Testing

The easiest way to test is with the tesing sample data installed and then the "contact categories" and the "article categories" menu items - see video
plus

182556a 31 Oct 2017 avatar brianteeman jtext
avatar brianteeman brianteeman - open - 31 Oct 2017
avatar brianteeman brianteeman - change - 31 Oct 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Oct 2017
Category Front End com_contact com_content com_newsfeeds Language & Strings
avatar brianteeman brianteeman - change - 31 Oct 2017
Labels Added: ? ?
avatar C-Lodder
C-Lodder - comment - 1 Nov 2017

JGLOBAL_COLLAPSE="Show less categories" are you should you want to go with that? What if it's not a category? Perhaps just

JGLOBAL_COLLAPSE="Show less"

?

avatar brianteeman
brianteeman - comment - 1 Nov 2017

@C-Lodder it is only used for categories

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

I have tested this item successfully on 5af6c86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18459.

avatar C-Lodder
C-Lodder - comment - 1 Nov 2017

@brianteeman - I was thinking more along the lines of, if we want to use it for 3rd party extensions or the collapse custom element in J4

avatar brianteeman
brianteeman - comment - 1 Nov 2017

@C-Lodder for accessibility the text should be meaningful so it needs the "category" part so you know what you are showing more of. I think what is confusing right now is the key that I have used for the PR as it is very generic and not specific to categories. As I stated in the original post I am seeking guidance from @infograf768 for the correct key to use and these keys are just for testing purposes. For your use case in J4 we can have different strings possibly with a sprintf

avatar dgt41
dgt41 - comment - 1 Nov 2017

@brianteeman I think @C-Lodder is right, correcting thins per view is gonna be a lot of repeated code instead of using a global collapse custom element specific to joomla's needs. That said this PR is against staging, so no CE thus it's ok the way you're doing it, but for J4 we need to use Custom Element for such behaviours

avatar brianteeman
brianteeman - comment - 1 Nov 2017

Do what you want for J4 - this is for J3. I have given up looking at j4 as all development has pretty much stopped while waiting for ux and a11y team

avatar dgt41
dgt41 - comment - 1 Nov 2017

as all development has pretty much stopped while waiting for ux and a11y team

Sadly that's true

avatar infograf768
infograf768 - comment - 1 Nov 2017

I these new strings are strictly related to categories, I suggest to change the constants to
JGLOBAL_EXPAND_CATEGORIES and JGLOBAL_COLLAPSE_CATEGORIES

avatar brianteeman
brianteeman - comment - 1 Nov 2017

Thanks @infograf768 i will update the pr with those keys

avatar brianteeman brianteeman - change - 1 Nov 2017
The description was changed
avatar brianteeman brianteeman - edited - 1 Nov 2017
avatar C-Lodder
C-Lodder - comment - 1 Nov 2017

Thanks @brianteeman

avatar C-Lodder C-Lodder - test_item - 1 Nov 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 1 Nov 2017

I have tested this item successfully on 891fa71

Based on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18459.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 1 Nov 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

I have tested this item successfully on 891fa71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18459.

avatar franz-wohlkoenig franz-wohlkoenig - change - 1 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Nov 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 1 Nov 2017
Labels Added: ?
avatar mbabker mbabker - change - 1 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-01 12:13:47
Closed_By mbabker
avatar mbabker mbabker - close - 1 Nov 2017
avatar mbabker mbabker - merge - 1 Nov 2017
avatar brianteeman
brianteeman - comment - 1 Nov 2017

Thanks

Add a Comment

Login with GitHub to post a comment