User tests: Successful: Unsuccessful:
This PR gives a visible indicator to the labels that have a popover.
Also it removes the "hand" cursor from labels that don't have a popover because this causes a confusion if the popover is just not working or if there is no help text available.
Isis and Protostar:
Remove Hand Cursor from labels
Add Pointer Cursor to labels
Add help cursor to labels with popover
Add help icon to labels with popover
Just see if it looks ok for you.
I actually wonder why this has not been made yet, if there is a reason for it, please just close the PR.
Labels that have a help text available will appear like that:
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
Labels |
Added:
?
|
I love it.
Maybe change a bit the size (for sure) and colour, i.e
.hasPopover::after, .control-label .hasTooltip::after {
content: "E";
font-family: IcoMoon;
font-size: 0.8rem;
margin-left: 0.2rem;
color: #1a3867;
}
I have been suggesting exactly this also for 4.0 to be able to cope with useful missing tips (alias being a good example).
In 4.0 though, would that create issues for a11y?
For j4 we have to do it completely different. I'm quite sure something accessible is already considered for J4 and I make sure we include it in the new template.
Regarding colour: I made it extra quite small and light because in Joomla 3 still a lot of labels have some (unneeded) helptext and it looks quite massive to have them all in blue. It's not brighter then the gray of inactive drop downs so it should be ok? Any other opinions about the colour?
I'm in favor of grey Color in @coolcat-creations proposal.
You appear to have modified the BS grid in the LESS file
I did not, but i compiled the protostar css with the less compiler in the template manager. Wrong? It was not generated by generatecss.php
There must be a bug somewhere or maybe it was from a previous commit from someone else, not sure. But it should be done with generatecss.php
Will not fight on the colour, but the size is still much too small imho.
Size is to small, true.
Since J4 implementation was mentioned here, here is what we've done so far (open with Chrome!) https://codepen.io/dgt41/pen/dzGJbK
which is based on: https://inclusive-components.design/tooltips-toggletips/
The main difference is that we're not using the question mark but the 'i' icon instead (and also we don't require some font library!)
@dgt41 ok in chrome I see it - so I guess the latest commit is ready to be tested ?
I find the icons very distracting and overwhelming since the majority of the labels have them.
It will be easier with them to remove the not needed desc for following versions though
Those useless strings have been removed in j4
@brianteeman ah - thought it was already for 3.7.x why can't we remove them already now? can that be merged in 3.9.x too?
Unfortunately the language policy in 3.x doesn't allow for that which is why it was done for j4
I understand, but does not prevent us to help people to see that there are tooltips at all? Will we get it merged?
Currently everything has a tooltip - even if it is useless
Does not apply for extensions. If an extension has no tooltip the cursor still changes on hover and that's imho a bad ux. So better to display the hint.
I have tested this item
Patch gives the expected result
I have tested this item
I like it and it's useful, to my opinion.
Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
I have tested this item
Further input: Normally every field in Joomla has an description. Therefore normally every Field has the "question-mark-icon". This icon need space and is on costs of a clean interface. Maybe a good idea to keep the old solution.
For Joomla 3 where every field has a description (thankfully we fixed that in Joomla 4) I don't see the need for this
For other extensions that have tooltips and you don't see on which field there are explanations.
Status | Ready to Commit | ⇒ | Pending |
RTC removed, as pointed out in #18452 (comment) this is going to change the display for every template being compiled with the Bootstrap files used in core. To me this is an OK change to make for the core templates, but not one that we should force onto all templates.
In J4, description is displayed and not in a popover. I see no point in adding this to J3 for it to be obsolete in J4.
This PR is 2 years old :-) / you are right that we don’t need it for J4 - but for Joomla 3 it still would increase usability. A new user can’t know that some labels (also 3rd Party components) have tooltips... since some J3 Sites will exist for at least 2 years it would be great to have this UX addition.
Yes for me its important to add this... More usefull
@brianteeman thank you - will look into this
Closing as no new features in J3 and this will be obsolete in J4. Thank you for your effort.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-05-04 21:19:40 |
Closed_By | ⇒ | Quy | |
Labels |
Added:
?
|
I have tested this item✅ successfully on bce992e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18452.