? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Oct 2017

Pull Request for Issue #18437.

Summary of Changes

from object loadObject() to array loadRowList(0)

Testing Instructions

see #18437 with php 7.2
test that Database check works as before

avatar alikon alikon - open - 30 Oct 2017
avatar alikon alikon - change - 30 Oct 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2017
Category Libraries
avatar alikon alikon - change - 31 Oct 2017
The description was changed
avatar alikon alikon - edited - 31 Oct 2017
avatar ghazal
ghazal - comment - 7 Dec 2017

This change helped me solve a restoration pb with Akeeba with PHP 7.2.0.
Same error as in issue #18437 after restoration from a server with PHP 7.1.7 to the one with
PHP 7.2.0.
I had to delete the file 2.5.0-2011-12-24.sql though.

Well, it seems that this has not been implemented yet in the most recent distribution. ???

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Dec 2017

@ghazal this Pull Request has not 2 successfully Tests.

avatar ghazal ghazal - test_item - 7 Dec 2017 - Tested successfully
avatar ghazal
ghazal - comment - 7 Dec 2017

I have tested this item successfully on 502c62c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

avatar alikon alikon - change - 7 Dec 2017
Title
[ChangeItem] - the check query should return array instead of object
[ChangeItem] - the check query should return array instead of object - PHP 7.2
avatar alikon alikon - edited - 7 Dec 2017
avatar ghazal
ghazal - comment - 7 Dec 2017

Quick check with J!3.8.3.RC - a fresh install - on a PHP 7.2.0 environment.
Same pb.
Same solution.
No surprise.

avatar Quy Quy - test_item - 24 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 24 Dec 2017

Tested with PR #19134.

Do you know why this was detected?
Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
which resulted:
Duplicate key name 'idx_client_id_parent_id_alias_language'

without this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'zcag2_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)

with this PR:

    Database schema version (3.8.2-2017-10-14) does not match CMS version (3.9.0-2017-12-22).
    Table 'ch56a_menu' does not have index 'idx_client_id_parent_id_alias_language'. (From file 2.5.0-2011-12-24.sql.)
    Table 'ch56a_content' does not have column 'note'. (From file 3.9.0-2017-12-22.sql.)
avatar alikon
alikon - comment - 29 Dec 2017

i'll look at it....

avatar alikon alikon - change - 29 Dec 2017
Labels Added: ?
avatar alikon
alikon - comment - 29 Dec 2017

@Quy can you re-check ?
@ghazal please re-test

avatar alikon alikon - change - 29 Dec 2017
The description was changed
avatar alikon alikon - edited - 29 Dec 2017
avatar Quy Quy - test_item - 29 Dec 2017 - Tested successfully
avatar Quy
Quy - comment - 29 Dec 2017

I have tested this item successfully on 86c4cc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

avatar ghazal ghazal - test_item - 29 Dec 2017 - Tested successfully
avatar ghazal
ghazal - comment - 29 Dec 2017

I have tested this item successfully on 86c4cc8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18443.

avatar franz-wohlkoenig franz-wohlkoenig - change - 29 Dec 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 29 Dec 2017

Ready to Commit after two successful tests.

avatar alikon
alikon - comment - 29 Dec 2017

can someone re-add the 3.8.4 milestone ?

avatar mbabker mbabker - change - 3 Jan 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-01-03 00:17:38
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 3 Jan 2018
avatar mbabker mbabker - merge - 3 Jan 2018

Add a Comment

Login with GitHub to post a comment