? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
30 Oct 2017

As title says.

Pull Request for Issue #18434

Summary of Changes

Adding the option to choose No User to filter by author in both managers.
ALSO: Correcting impossibility to filter by author in the Featured articles manager due to the absence of the array possibility since multiple was implemented

Testing Instructions

Edit an article and set it in the Publishing tab to No User using the Select in Created by field.
screen shot 2017-10-30 at 08 34 05
screen shot 2017-10-30 at 08 35 13

Expected result

Ability to filter authors by No user in both managers.

Test before and after patch.

After patch:
screen shot 2017-10-30 at 08 41 05

avatar infograf768 infograf768 - open - 30 Oct 2017
avatar infograf768 infograf768 - change - 30 Oct 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Oct 2017
Category Administration com_content
avatar infograf768 infograf768 - change - 30 Oct 2017
The description was changed
avatar infograf768 infograf768 - edited - 30 Oct 2017
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 30 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Oct 2017

I have tested this item successfully on 88d9573


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18440.

avatar infograf768
infograf768 - comment - 30 Oct 2017

@franz-wohlkoenig
Please also test #18445
Thanks.

avatar alikon alikon - test_item - 30 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 30 Oct 2017

I have tested this item successfully on 88d9573


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18440.

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Oct 2017

RTC after two successful tests.

avatar infograf768 infograf768 - change - 31 Oct 2017
Labels Added: ?
avatar infograf768
infograf768 - comment - 31 Oct 2017

Relaunched Travis

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 31 Oct 2017

Please also test #18445

@infograf768 done.

avatar infograf768
infograf768 - comment - 31 Oct 2017

tks, @franz-wohlkoenig

Looks like we have issues with Travis this morning.

avatar brianteeman
brianteeman - comment - 31 Oct 2017

As the null value is -select author- and the column name is authors shouldnt the no string be "no author" and not "no user"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18440.

avatar infograf768
infograf768 - comment - 1 Nov 2017

@brianteeman
See my response on the other PR.
#18445 (comment)

Please post there what you prefer.

avatar mbabker mbabker - change - 1 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-01 12:09:29
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 1 Nov 2017
avatar mbabker mbabker - merge - 1 Nov 2017

Add a Comment

Login with GitHub to post a comment