[#18426] - Update search bar layout
- Fixed in Code Base
- 1 Nov 2017
- Medium
- Build: staging
- # 18426
- Diff
- brianteeman:search_bar_layout
User tests: Successful: Unsuccessful:
Following best practice as applied elsewhere this PR adds the aria-hidden attribute to the font icon and ensures that the button has an aria-label so that the meaning of the button can be conveyed correctly to users for assistive technology
To test go to any admin page with a search bar and check the source cod of the search button. Before this pr it will be
<button type="submit" class="btn hasTooltip" title="" data-original-title="Search"> <span class="icon-search"></span> </button>
After this pr it will be
<button type="submit" class="btn hasTooltip" title="" aria-label="Search" data-original-title="Search"> <span class="icon-search" aria-hidden="true"></span> </button>
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18426.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:07:15 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 4879d6c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18426.