? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
24 Oct 2017

Pull Request for Issue #17557.

Summary of Changes

The fields content plugin gets the wrong context when indexing an article. This pr changes the indexer the way that as much information from the article are sent together to prepare the description and summary of the item to index.

Testing Instructions

  • Enable the content finder plugin (not the finder content plugin)
  • Create an article custom field
  • Create an article and add "Hello joomla {field 1}" into the description body (perhaps you have to replace 1 with the real id of the field)
  • Run the indexer in the smart search component
  • Create a smart search module for the front
  • Search for "joomla" in the smart search module on the front

Expected result

The search results to show the custom field values.

Actual result

The search results do contain {field 1} in the description.

avatar joomla-cms-bot joomla-cms-bot - change - 24 Oct 2017
Category Administration com_finder Front End Plugins
avatar laoneo laoneo - open - 24 Oct 2017
avatar laoneo laoneo - change - 24 Oct 2017
Status New Pending
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

@afri-can can you please test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18402.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 28 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Oct 2017

I have tested this item successfully on 68b4a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18402.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

Reminder for @afri-can.

avatar afri-can
afri-can - comment - 12 Nov 2017

Franz Hi,

I am still not sure how to test this, it seems to be a bit over my head

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 12 Nov 2017

@afri-can this is a Test for your Issue #17557.

avatar afri-can
afri-can - comment - 19 Nov 2017

Hi I tested this and the issue is resolved but has new issue, search result is showing the Spambots JS message in the search results
spam-botjs

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Nov 2017

@afri-can please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar afri-can afri-can - test_item - 19 Nov 2017 - Tested successfully
avatar afri-can
afri-can - comment - 19 Nov 2017

I have tested this item successfully on 68b4a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18402.

avatar afri-can
afri-can - comment - 19 Nov 2017

I have tested this item successfully on 68b4a83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18402.

avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Nov 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Nov 2017

Ready to Commit after two successful tests.

avatar mbabker mbabker - change - 19 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-19 13:05:38
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 19 Nov 2017
avatar mbabker mbabker - merge - 19 Nov 2017

Add a Comment

Login with GitHub to post a comment