? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
23 Oct 2017

Pull Request for Issue #18390

Summary of Changes

Set empty text for column in template installation adapter.
This is the same as in other adapters. Mysql do not trigger any errors if we do not declare such column but postgresql is more strict.

Testing Instructions

Install free template on postgresql.

Expected result

Installation success.

Actual result

Error.

Documentation Changes Required

No

avatar joomla-cms-bot joomla-cms-bot - change - 23 Oct 2017
Category Libraries
avatar csthomas csthomas - open - 23 Oct 2017
avatar csthomas csthomas - change - 23 Oct 2017
Status New Pending
avatar csthomas csthomas - change - 23 Oct 2017
Title
Set missing system_data for template installation
Set missing column system_data for template installation
avatar csthomas csthomas - edited - 23 Oct 2017
avatar Ria-Doshi
Ria-Doshi - comment - 23 Oct 2017

The above mentioned update worked. Thank you!

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Oct 2017

@Ria-Doshi please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar Ria-Doshi Ria-Doshi - test_item - 23 Oct 2017 - Tested successfully
avatar Ria-Doshi
Ria-Doshi - comment - 23 Oct 2017

I have tested this item successfully on c3c972a

Thank you. The install of 2 templates worked just fine.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18391.

avatar alikon alikon - test_item - 23 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 23 Oct 2017

I have tested this item successfully on c3c972a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18391.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 23 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-23 23:23:54
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 23 Oct 2017
avatar mbabker mbabker - merge - 23 Oct 2017

Add a Comment

Login with GitHub to post a comment