? Pending

User tests: Successful: Unsuccessful:

avatar izharaazmi
izharaazmi
14 Oct 2017

The state persistent filter for client id causes death end in menu manager navigation when the selected menutype is renamed in another page or session.

Pull Request for Issue #18228.

Summary of Changes

Reset filter if the matching menutype does not exist and allow the request to complete with unfiltered list.

Testing Instructions

Go to the menu items page:
joomla.example.com/administrator/index.php?option=com_menus&view=items
Choose a menu from the - Select menu - search tools dropdown.
Then go and edit the chosen menu:
joomla.example.com/administrator/index.php?option=com_menus&view=menu&layout=edit&id=<id of the menu type chosen in the previous page's search filter>
Change the menu's Menu Type.
Now go back to the first page. It crashes with a 500 Joomla error and there is no way to view the menu items anymore unless (I guess) logging out and logging back in or resetting the server session or reverting the menu type of the chosen menu to its old value.

Expected result

The joomla.example.com/administrator/index.php?option=com_menus&view=items page should work with the updated menu type in the filter or at least the filter should get reset.

Actual result

The joomla.example.com/administrator/index.php?option=com_menus&view=items page becomes unusable.

Documentation Changes Required

None

avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2017
Category Administration com_menus
avatar izharaazmi izharaazmi - open - 14 Oct 2017
avatar izharaazmi izharaazmi - change - 14 Oct 2017
Status New Pending
avatar csthomas csthomas - test_item - 20 Oct 2017 - Tested successfully
avatar csthomas
csthomas - comment - 20 Oct 2017

I have tested this item successfully on f6a92c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18336.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on f6a92c0

Using PR returning to chosen Menu got no Error The Menu type doesn't exist. instead of 500 Error.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18336.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 27 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-27 13:33:45
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Oct 2017
avatar mbabker mbabker - merge - 27 Oct 2017

Add a Comment

Login with GitHub to post a comment