? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Oct 2017

We were checking and reporting on the presence of mcrypt. We no longer need to do that as it is no longer a requirement and mcrypt itself is not present in php 7.2 so the checks would fail anyway then.

Didnt see the point in wrapping it in a conditional php version check as we dont need the info any more

See #18169 for the other mcrypt removal

avatar joomla-cms-bot joomla-cms-bot - change - 13 Oct 2017
Category Administration com_joomlaupdate Language & Strings
avatar brianteeman brianteeman - open - 13 Oct 2017
avatar brianteeman brianteeman - change - 13 Oct 2017
Status New Pending
avatar zero-24
zero-24 - comment - 14 Oct 2017

? Thanks @brianteeman

avatar Quy Quy - test_item - 17 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 17 Oct 2017

I have tested this item successfully on b7faaab

Code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18334.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 26 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

I have tested this item successfully on b7faaab


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18334.

avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 2 Nov 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-11-02 23:20:14
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 2 Nov 2017
avatar wilsonge wilsonge - merge - 2 Nov 2017
avatar brianteeman
brianteeman - comment - 2 Nov 2017

Thanks

avatar wilsonge
wilsonge - comment - 2 Nov 2017

Thanks!

Add a Comment

Login with GitHub to post a comment