? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
13 Oct 2017

Summary of Changes

Adds a missing closing double quote after rel="nofollow noopener noreferrer for _blank target

Testing Instructions

Code review
AND/OR:
Edit an article.
Add a Link A in tabulator Images and Links.
Set "URL Target Window" setting: "Open in new window"

13-10-_2017_17-21-30

Open article in front-end. Link is not visible and some following text is missing:

13-10-_2017_17-20-24

See HTML source code. Missing closing double quote with fatal consequences ;-)

13-10-_2017_17-23-53

Apply patch. Try again.

13-10-_2017_17-25-47

avatar joomla-cms-bot joomla-cms-bot - change - 13 Oct 2017
Category Front End Templates (site)
avatar ReLater ReLater - open - 13 Oct 2017
avatar ReLater ReLater - change - 13 Oct 2017
Status New Pending
avatar ReLater ReLater - change - 13 Oct 2017
The description was changed
avatar ReLater ReLater - edited - 13 Oct 2017
avatar Quy Quy - test_item - 13 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 13 Oct 2017

I have tested this item successfully on df342e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18329.

avatar alikon alikon - test_item - 13 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 13 Oct 2017

I have tested this item successfully on df342e2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18329.

avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 15 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-15 15:48:21
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 15 Oct 2017
avatar mbabker mbabker - merge - 15 Oct 2017

Add a Comment

Login with GitHub to post a comment