User tests: Successful: Unsuccessful:
Pull Request for Issue #18313 .
Fix JDatabaseDriverSqlsrv::limit()
and JDatabaseQuerySqlsrv::processLimit()
methods to support query with distinct and limit statements like:
SELECT DISTINCT * FROM t LIMIT n
in mssql should be:
SELECT DISTINCT TOP n * FROM t
See issue #18313
Sqlsrv syntax is correct.
Invalid sqlsrv syntax for query with distinct and limit.
No
Category | ⇒ | MS SQL Libraries |
Status | New | ⇒ | Pending |
@mruivo please mark this pr as successfull tested and open a new issue for the #18315 (comment) you reported
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-15 15:51:26 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
Is this the appropriate repo https://github.com/joomla-framework/database?
yup :)
Tested this on an mssql instance which now results in the following error:
[S0001][145] ORDER BY items must appear in the select list if SELECT DISTINCT is specified.