Feeling Lucky
?
[#18315] - Fix sqlsrv syntax for query SELECT with DISTINCT and LIMIT
- Fixed in Code Base
- 15 Oct 2017
- Medium
- Build: staging
- # 18315
- Diff
- csthomas:mssql_limit_distinct
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #18313 .
Summary of Changes
Fix JDatabaseDriverSqlsrv::limit() and JDatabaseQuerySqlsrv::processLimit() methods to support query with distinct and limit statements like:
SELECT DISTINCT * FROM t LIMIT nin mssql should be:
SELECT DISTINCT TOP n * FROM tTesting Instructions
See issue #18313
Expected result
Sqlsrv syntax is correct.
Actual result
Invalid sqlsrv syntax for query with distinct and limit.
Documentation Changes Required
No
joomla-cms-bot
- | Category | ⇒ | MS SQL Libraries |
| Status | New | ⇒ | Pending |
alikon
- comment
- 15 Oct 2017
@mruivo please mark this pr as successfull tested and open a new issue for the #18315 (comment) you reported
alikon
- comment
- 15 Oct 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18315.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 15 Oct 2017
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-15 15:51:26 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
csthomas
- comment
- 16 Nov 2017
Is this the appropriate repo https://github.com/joomla-framework/database?
wilsonge
- comment
- 16 Nov 2017
yup :)
Tested this on an mssql instance which now results in the following error:
[S0001][145] ORDER BY items must appear in the select list if SELECT DISTINCT is specified.