[#18308] - Optimize `ComponentHelper`: isInstalled and other
- Fixed in Code Base
- 1 Nov 2017
- Medium
- Build: staging
- # 18308
- Diff
- izharaazmi:component-helper
User tests: Successful: Unsuccessful:
Summary of Changes
Currently isInstalled does a separate query when called multiple times. Also CMS does not use it anywhere. Changed the implementation of ComponentHelper and ComponentRecord to use the same cached data as in isEnabled
Testing Instructions
ComponentHelper::isInstalled should return correct value for installed and not installed component.
- Check if this returns correct values for installed and not installed components:
// Following should normally return true
JComponentHelper::isInstalled('com_content');
// Following should normally return false - unless you really have such component installed.
JComponentHelper::isInstalled('com_whatever');- Now install some component say
com_testand check following
// true
JComponentHelper::isInstalled('com_test');
// true
JComponentHelper::isEnabled('com_test');- Now disable the component
com_testin extension manager and check following
// true
JComponentHelper::isInstalled('com_test');
// false
JComponentHelper::isEnabled('com_test');Documentation Changes Required
Update ComponentRecord doc.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
@franz-wohlkoenig Added detailed test instructions. Thanks for pointing out, I was little occupied that day and didn't want to hold the PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18308.
| Labels |
Added:
?
|
||
hm, complicated,
it is works, but now it produce warning for "non installed":
not really expected
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18308.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18308.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-01 12:03:36 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thank you for this change. I just stumbled upon this on a site that got ridiculously slow after upgrading to 3.8.1 and this change removed 140 queries and reduced the time it took for the DB down to a fifth.
@Hackwar Glad that it helped. @infograf768 was the first to point out this issue, thanks to him :)
@izharaazmi can you give more Test Instructions so People with less Dev-Skills can also test?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18308.