Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18293] - Added vote requires to array for list type

? ? Pending

User tests: Successful: Unsuccessful:

avatar tonypartridge
tonypartridge
9 Oct 2017

Vote has been set as a 'requires' on options. This allows it to function as expected, hiding the vote filtering options in lists

Pull Request for Issue #18281 and follow on from pull #18283.

@brianteeman @Quy here is the updated pull.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2017
Category ⇒ Libraries
avatar tonypartridge tonypartridge - open - 9 Oct 2017
avatar tonypartridge tonypartridge - change - 9 Oct 2017
Status New ⇒ Pending
avatar tonypartridge tonypartridge - change - 9 Oct 2017
The description was changed
avatar tonypartridge tonypartridge - edited - 9 Oct 2017
avatar tonypartridge
tonypartridge - comment - 9 Oct 2017

Bloody GIT!  I did it online lol

On 9 Oct 2017, 19:45 +0100, zero-24 notifications@github.com, wrote:

@zero-24 commented on this pull request.
In libraries/joomla/form/fields/list.php:

@@ -123,6 +123,12 @@ protected function getOptions()
{
continue;
}

please remove the whitespaces ;) just use a blank line ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar tonypartridge tonypartridge - change - 9 Oct 2017
Labels Added: ?
avatar Quy Quy - test_item - 9 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 9 Oct 2017

I have tested this item ✅ successfully on b96b932

THANK YOU!

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18293.

avatar brianteeman brianteeman - test_item - 9 Oct 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 9 Oct 2017

I have tested this item ✅ successfully on b96b932

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18293.

avatar franz-wohlkoenig franz-wohlkoenig - change - 10 Oct 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 10 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 11 Oct 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-10-11 12:32:36
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 11 Oct 2017
avatar mbabker mbabker - merge - 11 Oct 2017

Add a Comment

Login with GitHub to post a comment