Surely if you unpublish the plugin at the moment this stops the check from running?

@wilsonge see he comments on the issue this resolves.

We want it to always run since when filtering by votes with the plugin disabled causes and SQL error.

So just disable the filter when the plugin is disabled. We do that elsewhere

@brianteeman I disabled settings related to votes under Global Configurations > Articles, but no go, Please advise where else to disable the filter. Thanks.

Sorry if I wasn't clear. If you look at the filter_xml you will see that in other places we have code to conditionally load a filter. We need to do the same for this filter

It doesn’t work at present, requires vote but still shows even if plugin is
disabled

--
Tony Partridge

On 9 October 2017 at 14:06:54, Brian Teeman (notifications@github.com)
wrote:

Sorry if I wasn't clear. If you look at the filter_xml you will see that
in other places we have code to conditionally load a filter. We need to do
the same for this filter

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#18283 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVglpAspkRIc1HZwth3Md0vk_3apN40ks5sqhpugaJpZM4PyCOd
.

Ah sorry I didnt actually look at the code and see that it had requires=vote already

It’s fine I see the actual issue now, will do a or soon.

--
Tony Partridge

On 9 October 2017 at 18:03:18, Brian Teeman (notifications@github.com)
wrote:

Ah sorry I didnt actually look at the code and see that it had
requires=vote already

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#18283 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABVglns37tozB2XExKpLnUr2SWvhK6ITks5sqlHWgaJpZM4PyCOd
.