Feeling Lucky
?
[#18267] - Check if exists variable is equal to null instead use isset
- Fixed in Code Base
- 9 Oct 2017
- Medium
- Build: staging
- # 18267
- Diff
- csthomas:siterouter_simpler_check
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Simple improvement.
Do not use function isset() if you can compare to null only, for variables that exists.
Testing Instructions
Code review.
Or check the home page and one more page to see if links work as before.
Expected result
Joomla works as before.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
ggppdk
- comment
- 8 Oct 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18267.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 8 Oct 2017
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-09 23:22:49 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 65e9615
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18267.