Feeling Lucky
?
?
[#18251] - xml codestyle
- Fixed in Code Base
- 6 Oct 2017
- Medium
- Build: staging
- # 18251
- Diff
- brianteeman:moduleadmin
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Fixes one that was missed and another that was merged without checking
joomla-cms-bot
- | Category | ⇒ | Administration com_modules Front End com_content |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
zero-24
- comment
- 5 Oct 2017
Looks good to me
Quy
- comment
- 5 Oct 2017
Capitalize JYes and JNo. There are many instances of this in this file. Beyond the scope of this PR?
https://github.com/brianteeman/joomla-cms/blob/9cda48eb07a254e2c4ea22b2bdabaff24ab0b0ff/components/com_content/views/categories/tmpl/default.xml#L546
brianteeman
- comment
- 5 Oct 2017
fixed the first - for the Jno etc i will do that in another pr when these are merged or we will get conflict fun
Quy
- comment
- 5 Oct 2017
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18251.
zero-24
- comment
- 6 Oct 2017
I have tested this item
i have just done that myself
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18251.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-06 22:06:39 |
| Closed_By | ⇒ | mbabker | |
| Labels | |||
brianteeman
- comment
- 6 Oct 2017
thanks
Swap lines 709-710:
https://github.com/brianteeman/joomla-cms/blob/281ceee81b4e7d92f023581f74b80555e8d8fae2/components/com_content/views/categories/tmpl/default.xml#L710