? Pending

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
5 Oct 2017

Pull Request for Issue #18138 .

Summary of Changes

Change the session key for the tag filter in category model to be more unique between requests.
Add to session key category id and Itemid.

Testing Instructions

See issue #18138.

Expected result

On both menu pages articles are visible.

Actual result

Of first page article as OK
On second category page (without filter tags) there is no articles that does not have tags.

Documentation Changes Required

No

avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2017
Category Front End com_content
avatar csthomas csthomas - open - 5 Oct 2017
avatar csthomas csthomas - change - 5 Oct 2017
Status New Pending
avatar rpbikker
rpbikker - comment - 7 Oct 2017

Thank you, Tomasz,

I downloaded this file to my 3.8.1 install and I can confirm that this solves issue #18138 for me.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Oct 2017

@rpbikker please mark your Test as successfully:

  • Please open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"
avatar rpbikker rpbikker - test_item - 7 Oct 2017 - Tested successfully
avatar rpbikker
rpbikker - comment - 7 Oct 2017

I have tested this item successfully on 1b78c58


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18248.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Oct 2017

@qoolman21 @danielmreck @Hurmeli can you please test this Pull Request as you have confirmed Issue #18138.

avatar Uruisg Uruisg - test_item - 27 Oct 2017 - Tested successfully
avatar Uruisg
Uruisg - comment - 27 Oct 2017

I have tested this item successfully on 1b78c58

Tested successfully , thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18248.

avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Oct 2017

RTC after two successful tests.

avatar mbabker mbabker - change - 27 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-27 13:32:21
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 27 Oct 2017
avatar mbabker mbabker - merge - 27 Oct 2017

Add a Comment

Login with GitHub to post a comment