[#18236] - Update default_results.php
- Closed
- 26 Nov 2017
- Medium
- Build: staging
- # 18236
- Diff
- diddipoeler:patch-1
- Success hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr this build is pending Details
User tests: Successful: Unsuccessful:
display images in search results
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Category | ⇒ | Front End com_search |
| Status | New | ⇒ | Pending |
Please also refrain from using inline CSS. We have LESS files
| Labels |
Added:
?
|
||
is the code better now ?
@diddipoeler - unfortunately not:
- You're not using indentation
- You're still using inline styling
- You're using uppercase for
<?PHP. It should be lowercase
@diddipoeler - examples are cleared stated on the Joomla Coding Standards page
Keeping inline style for the moment, this should be
<?php // display images in search results ?>
<?php if (isset($result->image)) : ?>
<?php $image = json_decode($result->image); ?>
<?php $result->picture = $image->image_intro; ?>
<?php endif; ?>
<?php if (isset($result->picture) && $result->picture != '') : ?>
<div style="float: left;margin: 0px 0px;"><img src="<?php $this->escape($result->picture); ?>" width="50" alt="" /></div>
<?php endif; ?>
But, first, could you give an example of how this works please.?
Give detailed test instructions and screenshots.
@diddipoeler If no reply to our questions, we will close this.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18236.
| Status | Pending | ⇒ | Information Required |
If this Issue get no Response, it will be closed at 26th November 2017.
| Closed_Date | 2017-11-26 06:19:47 | ⇒ | 2017-11-26 06:19:48 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-11-26 06:19:47 |
| Closed_By | ⇒ | franz-wohlkoenig |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18236
This has been closed due to lack of response to the requests above – it can always be reopened.
Please follow Joomla Coding Standards.