? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Oct 2017

Simple PR to allow seecting multiple tags to a blog category menu item

PR for #13680

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2017
Category Front End com_content
avatar brianteeman brianteeman - open - 4 Oct 2017
avatar brianteeman brianteeman - change - 4 Oct 2017
Status New Pending
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 4 Oct 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Oct 2017

I have tested this item successfully on 069058b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18234.

avatar alikon alikon - test_item - 4 Oct 2017 - Tested successfully
avatar alikon
alikon - comment - 4 Oct 2017

I have tested this item successfully on 069058b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18234.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Oct 2017

RTC after two successful tests.

avatar pepperstreet
pepperstreet - comment - 4 Oct 2017
  1. ) None - does not work. Previous Filter is sticky.
    Please, could someone test the following issue? Another user from the german Joomla facebook-group and me have noticed that the filter can't be reset to "None". I mean, you can set the parameter; save the menuItem and the link URL changes accordingly... but the reloaded frontend menuItem does not revert to an un-filtered list?! The filtered results seem to be sticky. I have no clue, why this happens with no extra tag-filter option in the URL. Any other tag filter selection seem to work. Until you try "None" again.

  2. ) Multiple - any/all and child tags
    Multiple is a useful addition, but it seem to filter by ANY matches.
    For instance, the "Tagged Items" menu Item has "Item Selection Options", where you choose "Match Type ANY/ALL" and "Child Tags EXCLUDE/INCLUDE". Would it make sense to have these options, too?

Thanks for reading.

avatar brianteeman
brianteeman - comment - 4 Oct 2017

but the reloaded frontend menuItem does not revert to an un-filtered list?

Yes if you change the settings then you cant just reload the page as the filter is in the url. You will need to go back to the home page and then to the blog page to see the changes.

avatar brianteeman
brianteeman - comment - 4 Oct 2017

Multiple is a useful addition, but it seem to filter by ANY matches.
Yes that is correct

For instance, the "Tagged Items" menu Item has "Item Selection Options", where you choose "Match Type ANY/ALL" and "Child Tags EXCLUDE/INCLUDE". Would it make sense to have these options, too?

If you want that then use the tagged items menu item - no need to duplicate everything

avatar pepperstreet
pepperstreet - comment - 4 Oct 2017

@brianteeman
With reload, I mean to refresh the menuitem AND its link.
As far as I understand, the problem is the storage of the filter state.
I have tested only 1 blog menuitem, with different tag filters and none. I get the same issue:
#18138

  1. ) Multiple - filter options
    Yes, I know that this is some sort of duplication, but a complete parameter set, IMHO.
    The drawback with tagged items: It is a different component and menuItem type.
    So, it doesn't really help, if you already have a blog display.
avatar brianteeman
brianteeman - comment - 4 Oct 2017

Both of those are beyond the intended scope of this PR

avatar pepperstreet
pepperstreet - comment - 4 Oct 2017

@brianteeman Sorry, I just found the related issue too late.

avatar mbabker mbabker - close - 5 Oct 2017
avatar mbabker mbabker - merge - 5 Oct 2017
avatar mbabker mbabker - change - 5 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-05 12:21:01
Closed_By mbabker
Labels Added: ?
avatar brianteeman
brianteeman - comment - 5 Oct 2017

Thanks

Add a Comment

Login with GitHub to post a comment