[#18231] - Banner Tracks background
- Fixed in Code Base
- 6 Oct 2017
- Medium
- Build: staging
- Easy Test
- # 18231
- Diff
- brianteeman:tracks
User tests: Successful: Unsuccessful:
PR for #15269
I cant see any reason for the active class to be green and I cant find any other use of it so I simply removed the class from the template
Unless anyone has any better idea
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
| Status | New | ⇒ | Pending |
@brianteeman - can you also use the code I provided in this PR to: #15269 (comment)
cause currently you're only addressing half of it.
The margin:
You're also editing the BS CSS file in this PR which shouldn't be done
Ah I see the margin now. was hard to see on my screen as it was on a second row.
The only file i edited was media/jui/less/forms.less
In which case this should be done at template level. If you edit media/jui/less/forms.less, you to modify the bootstrap.css which should never happen
re the margin
your code was not correct as it is set here https://github.com/joomla/joomla-cms/blob/staging/media/jui/css/jquery.searchtools.css#L63
Hmm worked fine for me
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18231.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18231.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
RTC after two successful tests.
Before I merge, I have to ask since this is changing the Bootstrap stuff. Is there anywhere else this combination of classes is used producing the green display?
I couldnt find any
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-10-06 22:07:01 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 30731ed
Theres also a Alignment-Issue ("Begin date" and "End date" are not vertical aligned) :
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18231.