Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#18221] - Search with a / in the title

? ? Pending
Referenced as Related to: # 18432 # 18433

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Oct 2017

PR for #18220

Code by @hikashop-nicholas

Steps to reproduce the issue

Create a new article with the title "SHIM/SET"
Search for it on your frontend via the Joomla search.

Expected result

The result page should display a search result for it with a link to the article.

Actual result

The result page has a search result but without any link.

Warning: preg_replace(): Unknown modifier 't' in C:\Apache24\htdocs\cms\components\com_search\views\search\view.html.php on line 268

Test

Apply this PR and the title is displayed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Oct 2017
Category ⇒ Front End com_search
avatar brianteeman brianteeman - open - 4 Oct 2017
avatar brianteeman brianteeman - change - 4 Oct 2017
Status New ⇒ Pending
avatar eXsiLe95 eXsiLe95 - test_item - 4 Oct 2017 - Tested unsuccessfully
avatar eXsiLe95
eXsiLe95 - comment - 4 Oct 2017

I have tested this item ? unsuccessfully on b883cf5

System Information

  • Running on xampp v3.2.2
  • Windows 10 (1703: 15063:540)
  • Chrome 61.0.3163.100 (64bit)
  • PHP 7.1.7
  • Joomla! 3.8.1-rc2-dev

Testing instructions

  1. Fresh installation of Joomla! staging
  2. Create any article with Slash in name
  3. Search for created article

Before patch

An error occured, article was shown without headline.

With patch

Still, I can't search for any article with a slash "/" in the title. In my example, I created an article THM/MNI.

localhost-bugtesting-index php-search-searchword thm-mni searchphrase all

Tested @icampus

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18221.

9d936f3 4 Oct 2017 avatar brianteeman oops
avatar brianteeman brianteeman - change - 4 Oct 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 4 Oct 2017

@eXsiLe95 please can you retest - silly mistake by me leaving the comment in

avatar eXsiLe95 eXsiLe95 - test_item - 4 Oct 2017 - Tested successfully
avatar eXsiLe95
eXsiLe95 - comment - 4 Oct 2017

I have tested this item ✅ successfully on b883cf5

No problem!

After the quick fix, it now works as expected! (for details to testing, see post above)

image

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18221.
avatar Quy Quy - test_item - 4 Oct 2017 - Tested successfully
avatar Quy
Quy - comment - 4 Oct 2017

I have tested this item ✅ successfully on 3aa0983

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18221.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Oct 2017

@eXsiLe95 can you please retest?

avatar Quy
Quy - comment - 4 Oct 2017

@franz-wohlkoenig It is only coding style so it would not affect the test.

avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Oct 2017
Status Pending ⇒ Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Oct 2017

RTC after two successful tests.

avatar eXsiLe95 eXsiLe95 - test_item - 4 Oct 2017 - Tested successfully
avatar eXsiLe95
eXsiLe95 - comment - 4 Oct 2017

I have tested this item ✅ successfully on 3aa0983

I also tested this one. Works as expected. Didn't expect it not to work after code style changes, too.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18221.

avatar mbabker mbabker - change - 5 Oct 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-10-05 12:17:39
Closed_By ⇒ mbabker
Labels Added: ?
avatar mbabker mbabker - close - 5 Oct 2017
avatar mbabker mbabker - merge - 5 Oct 2017
avatar brianteeman
brianteeman - comment - 5 Oct 2017

thanks

Add a Comment

Login with GitHub to post a comment